Issue 3845002: Convert LOG(INFO) to VLOG(1) - base/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3845002: Convert LOG(INFO) to VLOG(1) - base/. (Closed)

Created:
10 years, 2 months ago by Peter Kasting

Modified:
9 years, 7 months ago

Reviewers:
brettw

CC:
chromium-reviews, brettw-cc_chromium.org, jshin+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Convert LOG(INFO) to VLOG(1) - base/. Also removes an "else" after "return" and aligns "<<" per style guide. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=62959

Patch Set 1 #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+45 lines, -51 lines)			Patch
M	base/crypto/symmetric_key_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	base/debug_util_unittest.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	base/event_trace_consumer_win_unittest.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	base/event_trace_controller_win_unittest.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	base/file_util_win.cc	View	3 chunks	+11 lines, -17 lines	0 comments	Download
M	base/i18n/char_iterator.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	base/i18n/word_iterator.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	base/message_loop_unittest.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	base/metrics/histogram.cc	View	4 chunks	+6 lines, -6 lines	0 comments	Download
M	base/nss_util.cc	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	base/observer_list_unittest.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	base/string_split.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	base/tools_sanity_unittest.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	base/watchdog.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Peter Kasting

On 2010/10/15 23:07:12, brettw wrote: > Is VLOG(1) better than VLOG(true)? VLOG's argument is an ...

10 years, 2 months ago (2010-10-16 01:04:56 UTC) #3

brettw

10 years, 2 months ago (2010-10-16 04:57:44 UTC) #4

okay, LGTM

On Fri, Oct 15, 2010 at 6:04 PM,  <pkasting@chromium.org> wrote:
> On 2010/10/15 23:07:12, brettw wrote:
>>
>> Is VLOG(1) better than VLOG(true)?
>
> VLOG's argument is an integral logging level, not a boolean.
>
> http://codereview.chromium.org/3845002/show
>

Expand Messages | Collapse Messages