Issue 3844006: Limit end-anchored regexps to testing end of string where possible.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3844006: Limit end-anchored regexps to testing end of string where possible. (Closed)

Created:
10 years, 2 months ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Visibility:
Public.

Description

Limit end-anchored regexps to testing end of string where possible. Committed: http://code.google.com/p/v8/source/detail?r=5661

Patch Set 1 #

Total comments: 2

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+188 lines, -20 lines)			Patch
M	src/arm/regexp-macro-assembler-arm.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/arm/regexp-macro-assembler-arm.cc	View	2 chunks	+13 lines, -1 line	2 comments	Download
M	src/ast.h	View	6 chunks	+11 lines, -6 lines	0 comments	Download
M	src/ast.cc	View	1 chunk	+40 lines, -9 lines	0 comments	Download
M	src/bytecodes-irregexp.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/ia32/regexp-macro-assembler-ia32.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/ia32/regexp-macro-assembler-ia32.cc	View	2 chunks	+11 lines, -1 line	0 comments	Download
M	src/interpreter-irregexp.cc	View	1 chunk	+9 lines, -0 lines	0 comments	Download
	src/jsregexp.cc	View	2 chunks	+13 lines, -1 line	0 comments	Download
M	src/regexp-macro-assembler.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/regexp-macro-assembler-irregexp.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/regexp-macro-assembler-irregexp.cc	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	src/regexp-macro-assembler-tracer.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/regexp-macro-assembler-tracer.cc	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	src/x64/regexp-macro-assembler-x64.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/x64/regexp-macro-assembler-x64.cc	View	2 chunks	+13 lines, -1 line	0 comments	Download
M	test/mjsunit/regexp.js	View	1 chunk	+58 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein

http://codereview.chromium.org/3844006/diff/1/2 File src/arm/regexp-macro-assembler-arm.cc (right): http://codereview.chromium.org/3844006/diff/1/2#newcode930 src/arm/regexp-macro-assembler-arm.cc:930: Label after_position; There is no NearLabel for ARM. http://codereview.chromium.org/3844006/diff/1/2#newcode932 ...

10 years, 2 months ago (2010-10-19 13:39:24 UTC) #1

LGTM

Expand Messages | Collapse Messages