Issue 384132: Small parseInt optimizations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 384132: Small parseInt optimizations (Closed)

Created:
11 years, 1 month ago by Jan de Mooij

Modified:
9 years, 7 months ago

Reviewers:
Lasse Reichstein, Erik Corry

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Sorry, this should have gone to http://codereview.chromium.org/391014 I added some tests and swapped the lhs and rhs of the && operator in v8natives.js as requested.

Patch Set 1 #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -4 lines)			Patch
M	src/runtime.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	src/v8natives.js	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	test/mjsunit/parse-int-float.js	View	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jan de Mooij

Sorry, this should have gone to http://codereview.chromium.org/391014 but my gcl was a bit messed up.

11 years, 1 month ago (2009-11-13 22:46:36 UTC) #1

Lasse Reichstein

11 years, 1 month ago (2009-11-16 11:47:30 UTC) #2

LGTM.
I'll land it later today or possibly tomorrow.

Expand Messages | Collapse Messages