Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: gcl.py

Issue 384128: Make gcl change in a read-only checkout a warning.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools/
Patch Set: Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gcl.py
===================================================================
--- gcl.py (revision 31940)
+++ gcl.py (working copy)
@@ -1000,10 +1000,6 @@
if not svn_info:
ErrorExit("Current checkout is unversioned. Please retry with a versioned "
"directory.")
- if (svn_info.get('URL', '').startswith('http:') and
- not FilterFlag(args, "--force")):
- ErrorExit("This is a read-only checkout. Retry in a read-write checkout "
- "or use --force to override.")
if (len(args) == 1):
filename = args[0]
@@ -1093,8 +1089,11 @@
ErrorExit("Empty changelist not saved")
change_info._files = new_cl_files
-
change_info.Save()
+ if svn_info.get('URL', '').startswith('http:'):
+ Warn("WARNING: Creating CL in a read-only checkout. You will not be "
+ "able to commit it!")
+
print change_info.name + " changelist saved."
if change_info.MissingTests():
Warn("WARNING: " + MISSING_TEST_MSG)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698