Enables most DB layout tests in test_shell.

Enables most DB layout tests in test_shell.

TEST=none
BUG=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=31997

[dumi, 2009-11-13 09:55:11]

Still need to understand/fix a couple of weirdnesses, but the code shouldn't
change much.

[dglazkov, 2009-11-13 17:14:13]

LGTM!

[michaeln, 2009-11-13 17:39:49]

http://codereview.chromium.org/384118/diff/1/5
File webkit/tools/test_shell/simple_database_system.h (right):

http://codereview.chromium.org/384118/diff/1/5#newcode14
Line 14: class SimpleDatabaseSystem : public
webkit_database::DatabaseTracker::Observer {
consider having this class implement the WebDatabase::Observer interface
directly... then you don't need the separate test_shell_web_datbase_observer.h
file or class... just one fewer moving part to assemble in the 'simple' system.

http://codereview.chromium.org/384118/diff/1/5#newcode20
Line 20: base::PlatformFile OpenFile(const string16& vfs_file_name,
as was done in DatabaseDispatcherHost.h, comments in this class interface to
separate these methods into groups

[dumi, 2009-11-13 23:03:40]

http://codereview.chromium.org/384118/diff/1/5
File webkit/tools/test_shell/simple_database_system.h (right):

http://codereview.chromium.org/384118/diff/1/5#newcode14
Line 14: class SimpleDatabaseSystem : public
webkit_database::DatabaseTracker::Observer {
On 2009/11/13 17:39:49, michaeln wrote:
> consider having this class implement the WebDatabase::Observer interface
> directly... then you don't need the separate test_shell_web_datbase_observer.h
> file or class... just one fewer moving part to assemble in the 'simple'
system.

done.

http://codereview.chromium.org/384118/diff/1/5#newcode20
Line 20: base::PlatformFile OpenFile(const string16& vfs_file_name,
On 2009/11/13 17:39:49, michaeln wrote:
> as was done in DatabaseDispatcherHost.h, comments in this class interface to
> separate these methods into groups
> 

done.

[michaeln, 2009-11-13 23:08:49]

LGTM!