Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: src/arm/fast-codegen-arm.cc

Issue 384085: Fix bug in the top-level compiler: write barrier for assignments to context slots:... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/arm/fast-codegen-arm.cc
===================================================================
--- src/arm/fast-codegen-arm.cc (revision 3293)
+++ src/arm/fast-codegen-arm.cc (working copy)
@@ -862,10 +862,10 @@
int offset = FixedArray::kHeaderSize + slot->index() * kPointerSize;
// Update the write barrier for the array store with r0 as the scratch
- // register. Skip the write barrier if r0 is a smi.
+ // register. Skip the write barrier if the value written (r1) is a smi.
// The smi test is part of RecordWrite on other platforms, not on arm.
Label exit;
- __ tst(r0, Operand(kSmiTagMask));
+ __ tst(r1, Operand(kSmiTagMask));
__ b(eq, &exit);
__ mov(r2, Operand(offset));
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698