 Chromium Code Reviews
 Chromium Code Reviews Issue 384078:
  Fast-codegen: Added support for arguments in functions.  (Closed)
    
  
    Issue 384078:
  Fast-codegen: Added support for arguments in functions.  (Closed) 
  | OLD | NEW | 
|---|---|
| 1 // Copyright 2009 the V8 project authors. All rights reserved. | 1 // Copyright 2009 the V8 project authors. All rights reserved. | 
| 2 // Redistribution and use in source and binary forms, with or without | 2 // Redistribution and use in source and binary forms, with or without | 
| 3 // modification, are permitted provided that the following conditions are | 3 // modification, are permitted provided that the following conditions are | 
| 4 // met: | 4 // met: | 
| 5 // | 5 // | 
| 6 // * Redistributions of source code must retain the above copyright | 6 // * Redistributions of source code must retain the above copyright | 
| 7 // notice, this list of conditions and the following disclaimer. | 7 // notice, this list of conditions and the following disclaimer. | 
| 8 // * Redistributions in binary form must reproduce the above | 8 // * Redistributions in binary form must reproduce the above | 
| 9 // copyright notice, this list of conditions and the following | 9 // copyright notice, this list of conditions and the following | 
| 10 // disclaimer in the documentation and/or other materials provided | 10 // disclaimer in the documentation and/or other materials provided | 
| (...skipping 111 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 122 } | 122 } | 
| 123 } | 123 } | 
| 124 } | 124 } | 
| 125 // Invoke the platform-dependent code generator to do the actual | 125 // Invoke the platform-dependent code generator to do the actual | 
| 126 // declaration the global variables and functions. | 126 // declaration the global variables and functions. | 
| 127 DeclareGlobals(array); | 127 DeclareGlobals(array); | 
| 128 } | 128 } | 
| 129 } | 129 } | 
| 130 | 130 | 
| 131 | 131 | 
| 132 void FastCodeGenerator::VisitCondition(Expression* expression, | |
| 
William Hesse
2009/11/12 09:56:49
This should be a separate change.  Also, all place
 
Lasse Reichstein
2009/11/13 08:54:37
Removed for now.
 | |
| 133 Label* on_true, | |
| 134 Label* on_false) { | |
| 135 ASSERT(expression->context() >= Expression::kTest); | |
| 136 Label* saved_true_label = true_label_; | |
| 137 Label* saved_false_label = false_label_; | |
| 138 true_label_ = on_true; | |
| 139 false_label_ = on_false; | |
| 140 Visit(expression); | |
| 141 true_label_ = saved_true_label; | |
| 142 false_label_ = saved_false_label; | |
| 143 } | |
| 144 | |
| 145 | |
| 132 void FastCodeGenerator::SetFunctionPosition(FunctionLiteral* fun) { | 146 void FastCodeGenerator::SetFunctionPosition(FunctionLiteral* fun) { | 
| 133 if (FLAG_debug_info) { | 147 if (FLAG_debug_info) { | 
| 134 CodeGenerator::RecordPositions(masm_, fun->start_position()); | 148 CodeGenerator::RecordPositions(masm_, fun->start_position()); | 
| 135 } | 149 } | 
| 136 } | 150 } | 
| 137 | 151 | 
| 138 | 152 | 
| 139 void FastCodeGenerator::SetReturnPosition(FunctionLiteral* fun) { | 153 void FastCodeGenerator::SetReturnPosition(FunctionLiteral* fun) { | 
| 140 if (FLAG_debug_info) { | 154 if (FLAG_debug_info) { | 
| 141 CodeGenerator::RecordPositions(masm_, fun->end_position()); | 155 CodeGenerator::RecordPositions(masm_, fun->end_position()); | 
| (...skipping 380 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 522 | 536 | 
| 523 void FastCodeGenerator::VisitThisFunction(ThisFunction* expr) { | 537 void FastCodeGenerator::VisitThisFunction(ThisFunction* expr) { | 
| 524 UNREACHABLE(); | 538 UNREACHABLE(); | 
| 525 } | 539 } | 
| 526 | 540 | 
| 527 | 541 | 
| 528 #undef __ | 542 #undef __ | 
| 529 | 543 | 
| 530 | 544 | 
| 531 } } // namespace v8::internal | 545 } } // namespace v8::internal | 
| OLD | NEW |