Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 384059: linux: work around "flash does not register any clicks" bug (Closed)

Created:
11 years, 1 month ago by Evan Martin
Modified:
9 years, 7 months ago
Reviewers:
piman
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

linux: work around "flash does not register any clicks" bug I had a flash of inspiration! Setting GDK_NATIVE_WINDOWS in the environment doesn't work because we don't propagate the setting down into the plugin subprocess. I confirmed that setting it manually fixes it. That is, on this computer I previously had the no-clicks bug and with this change the problem is solved. Note: there are multiple confusing levels to this bug; if nspluginwrapper gets involved I still encounter the problem. But this definitely fixes the problem for me. BUG=20654 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=31734

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M chrome/plugin/plugin_thread.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Evan Martin
11 years, 1 month ago (2009-11-11 23:40:08 UTC) #1
piman
11 years, 1 month ago (2009-11-11 23:48:39 UTC) #2
LGTM. I don't think it can hurt.

Powered by Google App Engine
This is Rietveld 408576698