Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 3838008: Script to diagnose and fix TPM problems in recovery mode. (Closed)

Created:
10 years, 2 months ago by Luigi Semenzato
Modified:
9 years, 7 months ago
Reviewers:
Randall Spangler
CC:
chromium-os-reviews_chromium.org, Randall Spangler, gauravsh, Luigi Semenzato, Bill Richardson
Visibility:
Public.

Description

Script to diagnose and fix TPM problems in recovery mode. Change-Id: I750bbc5c87bf824f0450986dd92be0cb8aea5555 BUG= TEST= Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=3e3704f

Patch Set 1 #

Patch Set 2 : just more changes #

Patch Set 3 : whitespace #

Patch Set 4 : first working version with working test #

Total comments: 4

Patch Set 5 : remove confusing and at best marginally useful statement #

Unified diffs Side-by-side diffs Delta from patch set Stats (+537 lines, -0 lines) Patch
A utility/chromeos_tpm_recovery View 1 2 3 4 1 chunk +324 lines, -0 lines 0 comments Download
A utility/chromeos_tpm_recovery_test View 1 chunk +213 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Luigi Semenzato
First stab at an all-encompassing TPM fixit script. First script: chromeos_tpm_recovery chromeos_tpm_recovery runs in recovery ...
10 years, 2 months ago (2010-10-22 21:47:01 UTC) #1
Randall Spangler
http://codereview.chromium.org/3838008/diff/6001/7001 File utility/chromeos_tpm_recovery (right): http://codereview.chromium.org/3838008/diff/6001/7001#newcode20 utility/chromeos_tpm_recovery:20: awk=/usr/bin/awk $USR_BIN/awk? http://codereview.chromium.org/3838008/diff/6001/7001#newcode273 utility/chromeos_tpm_recovery:273: ensure_tcsd_is_not_running This won't work, because ...
10 years, 2 months ago (2010-10-22 23:20:13 UTC) #2
Luigi Semenzato
Thank you for the comment. Please keep sending them! http://codereview.chromium.org/3838008/diff/6001/7001 File utility/chromeos_tpm_recovery (right): http://codereview.chromium.org/3838008/diff/6001/7001#newcode20 utility/chromeos_tpm_recovery:20: ...
10 years, 2 months ago (2010-10-23 00:36:10 UTC) #3
Randall Spangler
10 years, 2 months ago (2010-10-25 17:57:51 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698