Fix Valgrind unittests by forcing illegal memory accesses to happen unconditi...

Fix Valgrind unittests by forcing illegal memory accesses to happen unconditionally.

BUG=none
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=62992

[oshima, 2010-10-18 23:55:43]

LGTM

- oshima

On Mon, Oct 18, 2010 at 4:52 PM, <pkasting@chromium.org> wrote:

> Reviewers: Lei Zhang, oshima,
>
> Description:
> Fix Valgrind unittests by forcing illegal memory accesses to happen
> unconditionally.
>
> BUG=none
> TEST=none
>
> Please review this at http://codereview.chromium.org/3838006/show
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>  M     base/tools_sanity_unittest.cc
>
>
> Index: base/tools_sanity_unittest.cc
> ===================================================================
> --- base/tools_sanity_unittest.cc       (revision 62960)
> +++ base/tools_sanity_unittest.cc       (working copy)
> @@ -36,11 +36,13 @@
>  }
>
>  void ReadValueOutOfArrayBoundsLeft(char *ptr) {
> -  VLOG(1) << "Reading a byte out of bounds: " << ptr[-2];
> +  char c = ptr[-2];
> +  VLOG(1) << "Reading a byte out of bounds: " << c;
>  }
>
>  void ReadValueOutOfArrayBoundsRight(char *ptr, size_t size) {
> -  VLOG(1) << "Reading a byte out of bounds: " << ptr[size + 1];
> +  char c = ptr[size + 1];
> +  VLOG(1) << "Reading a byte out of bounds: " << c;
>  }
>
>  // This is harmless if you run it under Valgrind thanks to redzones.
>
>
>

[Lei Zhang, 2010-10-18 23:55:50]

LGTM