chrome/browser/views/external_protocol_dialog.cc - Issue 3836005: Move pe_image and registry from base to base/win and use the namespace. It re...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/views/external_protocol_dialog.cc

Issue 3836005: Move pe_image and registry from base to base/win and use the namespace. It re... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: '' Created 10 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/views/external_protocol_dialog.cc

===================================================================

--- chrome/browser/views/external_protocol_dialog.cc (revision 62848)

+++ chrome/browser/views/external_protocol_dialog.cc (working copy)

@@ -7,10 +7,10 @@

#include "app/l10n_util.h"

#include "app/message_box_flags.h"

#include "base/metrics/histogram.h"

-#include "base/registry.h"

#include "base/string_util.h"

#include "base/thread.h"

#include "base/utf_string_conversions.h"

+#include "base/win/registry.h"

#include "chrome/browser/browser_process.h"

#include "chrome/browser/external_protocol_handler.h"

#include "chrome/browser/tab_contents/tab_contents.h"

@@ -160,7 +160,7 @@

std::wstring url_spec = ASCIIToWide(url.possibly_invalid_spec());

std::wstring cmd_key_path =

ASCIIToWide(url.scheme() + "\\shell\\open\\command");

- RegKey cmd_key(HKEY_CLASSES_ROOT, cmd_key_path.c_str(), KEY_READ);

+ base::win::RegKey cmd_key(HKEY_CLASSES_ROOT, cmd_key_path.c_str(), KEY_READ);

size_t split_offset = url_spec.find(L':');

if (split_offset == std::wstring::npos)

return std::wstring();

« no previous file with comments | « chrome/browser/shell_integration_win.cc ('k') | chrome/browser/views/shell_dialogs_win.cc » ('j') | no next file with comments »