Issue 3836003: Revert 62189 - [Mac] Update Clear Browsing dialog for proper functioning from...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3836003: Revert 62189 - [Mac] Update Clear Browsing dialog for proper functioning from... (Closed)

Created:
10 years, 2 months ago by Avi (use Gerrit)

Modified:
9 years, 7 months ago

Reviewers:
Avi (use Gerrit), Elliot Glaysher, Raz Mathias

CC:
chromium-reviews, pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Revert 62189 - [Mac] Update Clear Browsing dialog for proper functioning from incognito windows, only hide server data delete if switch is not set. Mirror to r62147. nib changes: - for the five "clear server data" items, hidden bound to !owner.isSyncVisible - for the "clear server data" button, enabled bound to owner.isSyncEnabled, enabled2 bound to !isClearing BUG=none TEST=none Review URL: http://codereview.chromium.org/3674005 TBR=avi@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=62782

Patch Set 1 #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+43 lines, -108 lines)			Patch
M	chrome/app/nibs/ClearBrowsingData.xib	View	8 chunks	+29 lines, -81 lines	0 comments	Download
M	chrome/browser/cocoa/clear_browsing_data_controller.h	View	3 chunks	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/cocoa/clear_browsing_data_controller.mm	View	5 chunks	+14 lines, -24 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Elliot Glaysher

LGTM as long as there hasn't been any xib changes between the reverts.

10 years, 2 months ago (2010-10-15 20:20:54 UTC) #3

Avi (use Gerrit)

10 years, 2 months ago (2010-10-15 20:23:05 UTC) #4

On 2010/10/15 20:20:54, Elliot Glaysher wrote:
> LGTM as long as there hasn't been any xib changes between the reverts.

Verified that there hasn't.

Expand Messages | Collapse Messages