chrome/browser/chromeos/tab_closeable_state_watcher_browsertest.cc - Issue 3834002: Make all browser code use browser::Navigate to open tabs....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/tab_closeable_state_watcher_browsertest.cc

Issue 3834002: Make all browser code use browser::Navigate to open tabs.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: '' Created 10 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chromeos/tab_closeable_state_watcher_browsertest.cc

===================================================================

--- chrome/browser/chromeos/tab_closeable_state_watcher_browsertest.cc (revision 64601)

+++ chrome/browser/chromeos/tab_closeable_state_watcher_browsertest.cc (working copy)

@@ -37,9 +37,7 @@

protected:

// Wrapper for Browser::AddTabWithURL

void AddTabWithURL(Browser* browser, const GURL& url) {

- Browser::AddTabWithURLParams params(url, PageTransition::TYPED);

- params.index = 0;

- browser->AddTabWithURL(&params);

+ AddTabAtIndexToBrowser(browser, 0, url, PageTransition::TYPED);

// Wait for page to finish loading.

ui_test_utils::WaitForNavigation(

&browser->GetSelectedTabContents()->controller());