Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5020)

Unified Diff: chrome/browser/browser_focus_uitest.cc

Issue 3834002: Make all browser code use browser::Navigate to open tabs.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/browser_browsertest.cc ('k') | chrome/browser/browser_init.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/browser_focus_uitest.cc
===================================================================
--- chrome/browser/browser_focus_uitest.cc (revision 64601)
+++ chrome/browser/browser_focus_uitest.cc (working copy)
@@ -217,11 +217,8 @@
ui_test_utils::NavigateToURL(browser(), url);
// Create several tabs.
- for (int i = 0; i < 4; ++i) {
- Browser::AddTabWithURLParams params(url, PageTransition::TYPED);
- browser()->AddTabWithURL(&params);
- EXPECT_EQ(browser(), params.target);
- }
+ for (int i = 0; i < 4; ++i)
+ browser()->AddSelectedTabWithURL(url, PageTransition::TYPED);
// Alternate focus for the tab.
const bool kFocusPage[3][5] = {
@@ -296,9 +293,7 @@
browser()->FocusLocationBar();
// Create a 2nd tab.
- Browser::AddTabWithURLParams params(url, PageTransition::TYPED);
- browser()->AddTabWithURL(&params);
- EXPECT_EQ(browser(), params.target);
+ browser()->AddSelectedTabWithURL(url, PageTransition::TYPED);
// Focus should be on the recently opened tab page.
ASSERT_TRUE(IsViewFocused(VIEW_ID_TAB_CONTAINER_FOCUS_VIEW));
« no previous file with comments | « chrome/browser/browser_browsertest.cc ('k') | chrome/browser/browser_init.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698