Make all browser code use browser::Navigate to open tabs....

chrome/browser/browser.h

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_BROWSER_H_
 #define CHROME_BROWSER_BROWSER_H_
 #pragma once
 
 #include <map>
 #include <set>
@@ skipping 325 matching lines @@
   // |relative_index| gives the index of the url into the number of tabs that
   // are going to be opened. For example, if three urls are passed in on the
   // command line this is invoked three times with the values 0, 1 and 2.
   int GetIndexForInsertionDuringRestore(int relative_index);
 
   // Adds a selected tab with the specified URL and transition, returns the
   // created TabContents.
   TabContents* AddSelectedTabWithURL(const GURL& url,
                                      PageTransition::Type transition);
 
-  // Parameters for AddTabWithURL.
-  struct AddTabWithURLParams {
-    AddTabWithURLParams(const GURL& a_url, PageTransition::Type a_transition);
-    ~AddTabWithURLParams();
-
-    // Basic configuration.
-    GURL url;
-    GURL referrer;
-    PageTransition::Type transition;
-
-    // The index to open the tab at. This could be ignored by the tabstrip
-    // depending on the combination of |add_types| specified.
-    int index;
-
-    // A bitmask of values defined in TabStripModel::AddTabTypes.
-    // The default is ADD_SELECTED.
-    int add_types;
-
-    // If non-NULL, used to render the tab.
-    SiteInstance* instance;
-
-    // If non-empty, the new tab is an app tab.
-    std::string extension_app_id;
-
-    // The browser where the tab was added.
-    Browser* target;
-
-   private:
-    AddTabWithURLParams();
-  };
-
-  // Adds a tab to the browser (or another) and returns the created TabContents.
-  TabContents* AddTabWithURL(AddTabWithURLParams* params);
-
   // Add a new tab, given a TabContents. A TabContents appropriate to
   // display the last committed entry is created and returned.
   TabContents* AddTab(TabContents* tab_contents, PageTransition::Type type);
 
   // Add a tab with its session history restored from the SessionRestore
   // system. If select is true, the tab is selected. |tab_index| gives the index
   // to insert the tab at. |selected_navigation| is the index of the
   // TabNavigation in |navigations| to select. If |extension_app_id| is
   // non-empty the tab is an app tab and |extension_app_id| is the id of the
   // extension. If |pin| is true and |tab_index|/ is the last pinned tab, then
@@ skipping 531 matching lines @@
   // browser.
   //
   // Returns false if it was not handled. In this case, the method may also
   // modify |disposition| to a more suitable value.
   bool HandleCrossAppNavigation(TabContents* source,
                                 const GURL& url,
                                 const GURL& referrer,
                                 WindowOpenDisposition *disposition,
                                 PageTransition::Type transition);
 
-  // The low-level function that other OpenURL...() functions call.  This
-  // determines the appropriate SiteInstance to pass to AddTabWithURL(), focuses
-  // the newly created tab as needed, and does other miscellaneous housekeeping.
-  // |add_types| is a bitmask of TabStripModel::AddTabTypes and may be used to
-  // pass specific flags to the TabStripModel. |add_types| is only used if
-  // the disposition is NEW_WINDOW or SUPPRESS_OPEN.
-  void OpenURLAtIndex(TabContents* source,
-                      const GURL& url,
-                      const GURL& referrer,
-                      WindowOpenDisposition disposition,
-                      PageTransition::Type transition,
-                      int index,
-                      int add_types);
-
   // Shows the Find Bar, optionally selecting the next entry that matches the
   // existing search string for that Tab. |forward_direction| controls the
   // search direction.
   void FindInPage(bool find_next, bool forward_direction);
 
   // Closes the frame.
   // TODO(beng): figure out if we need this now that the frame itself closes
   //             after a return to the message loop.
   void CloseFrame();
 
@@ skipping 177 matching lines @@
   // The profile's tab restore service. The service is owned by the profile,
   // and we install ourselves as an observer.
   TabRestoreService* tab_restore_service_;
 
   scoped_ptr<InstantController> instant_;
 
   DISALLOW_COPY_AND_ASSIGN(Browser);
 };
 
 #endif  // CHROME_BROWSER_BROWSER_H_