Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4956)

Unified Diff: chrome/browser/blocked_popup_container.cc

Issue 3832005: Don't display the file select dialog from invisible windows.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/renderer/render_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/blocked_popup_container.cc
===================================================================
--- chrome/browser/blocked_popup_container.cc (revision 62133)
+++ chrome/browser/blocked_popup_container.cc (working copy)
@@ -35,6 +35,9 @@
blocked_popups_.push_back(BlockedPopup(tab_contents, bounds));
tab_contents->set_delegate(this);
+ // Since the new tab_contents will not be showed, call WasHidden to change
+ // its status on both RenderViewHost and RenderView.
+ tab_contents->WasHidden();
if (blocked_popups_.size() == 1)
owner_->PopupNotificationVisibilityChanged(true);
}
@@ -45,6 +48,8 @@
i != blocked_popups_.end(); ++i) {
if (i->tab_contents == tab_contents) {
tab_contents->set_delegate(NULL);
+ // We needn't call WasRestored to change its status because the
+ // TabContents::AddNewContents will do it.
owner_->AddNewContents(tab_contents, NEW_POPUP, i->bounds, true);
blocked_popups_.erase(i);
break;
« no previous file with comments | « no previous file | chrome/renderer/render_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698