Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 383005: Revert r3032 that uses push instead of 'sub esp, size'. This change... (Closed)

Created:
11 years, 1 month ago by Mads Ager (chromium)
Modified:
9 years, 7 months ago
Reviewers:
fschneider
CC:
v8-dev
Visibility:
Public.

Description

Revert r3032 that uses push instead of 'sub esp, size'. This change leads to stack corruption in 32-bit version of V8. See http://code.google.com/p/chromium/issues/detail?id=27227 for a reproducible case. Since this is only an issue on 32-bit V8 I think this has got something to do with the UnsafeSmi handling that we do on ia32. I'm reverting for now so we can push a fix, but we should track down the issue and create a regression test for this. Committed: http://code.google.com/p/v8/source/detail?r=3263

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -18 lines) Patch
M src/ia32/virtual-frame-ia32.cc View 1 chunk +8 lines, -9 lines 0 comments Download
M src/x64/virtual-frame-x64.cc View 1 chunk +8 lines, -9 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mads Ager (chromium)
11 years, 1 month ago (2009-11-10 14:32:23 UTC) #1
Mads Ager (chromium)
11 years, 1 month ago (2009-11-10 14:57:33 UTC) #2
TBR

Powered by Google App Engine
This is Rietveld 408576698