Issue 3829002: Change hostname to ip address if we can get it from ifconfig.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3829002: Change hostname to ip address if we can get it from ifconfig. (Closed)

Created:
10 years, 2 months ago by sosa

Modified:
9 years, 6 months ago

Reviewers:
petkov, kmixter1

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
http://git.chromium.org/git/crosutils.git

Visibility:
Public.

Description

Change hostname to ip address if we can get it from ifconfig. Change-Id: I6719ffe0c3c9356cf48b391b0a257e268eec94dc BUG=7780 TEST=Ran it with cros_run_vm_test. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=ccfa2ac

Patch Set 1 #

Total comments: 1

Patch Set 2 : Cleanup #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -1 line)			Patch
	M	image_to_live.sh	View	1	2 chunks	+15 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

petkov

LGTM with an optional suggestion. You may also want to add a comment why you're ...

10 years, 2 months ago (2010-10-15 16:37:45 UTC) #2

kmixter1

10 years, 2 months ago (2010-10-15 17:13:28 UTC) #3

LGTM

On Fri, Oct 15, 2010 at 9:37 AM, <petkov@chromium.org> wrote:

> LGTM with an optional suggestion. You may also want to add a comment why
> you're
> getting the IP rather than using HOSTNAME.
>
>
>
> http://codereview.chromium.org/3829002/diff/1/2
> File image_to_live.sh (right):
>
> http://codereview.chromium.org/3829002/diff/1/2#newcode75
> image_to_live.sh:75: hostname=$(ifconfig eth0 \
> too much awk for my taste :-) consider:
>
> ifconfig eth0 | grep 'inet addr' | sed 's/.\+inet addr:\(\S\+\).\+/\1/'
>
>
> http://codereview.chromium.org/3829002/show
>

Expand Messages | Collapse Messages