Issue 3828016: Make state stack thread local. When using Lockers the state stacks of...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3828016: Make state stack thread local. When using Lockers the state stacks of... (Closed)

Created:
10 years, 2 months ago by Mads Ager (chromium)

Modified:
9 years, 7 months ago

Reviewers:
Kasper Lund

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Make state stack thread local. When using Lockers the state stacks of multiple threads got mixed up so that the current state could be an already deallocated state from another thread. Committed: http://code.google.com/p/v8/source/detail?r=5665

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -47 lines)			Patch
M	src/top.h	View		3 chunks	+16 lines, -0 lines	0 comments	Download
M	src/top.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/vm-state.h	View		3 chunks	+5 lines, -5 lines	0 comments	Download
M	src/vm-state.cc	View	1	1 chunk	+0 lines, -39 lines	0 comments	Download
M	src/vm-state-inl.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Kasper Lund

LGTM. http://codereview.chromium.org/3828016/diff/1/5 File src/vm-state.cc (right): http://codereview.chromium.org/3828016/diff/1/5#newcode34 src/vm-state.cc:34: This is now empty. Should we get rid ...

10 years, 2 months ago (2010-10-20 05:44:45 UTC) #2

Mads Ager (chromium)

10 years, 2 months ago (2010-10-20 05:53:25 UTC) #3

http://codereview.chromium.org/3828016/diff/1/5
File src/vm-state.cc (right):

http://codereview.chromium.org/3828016/diff/1/5#newcode34
src/vm-state.cc:34: 
On 2010/10/20 05:44:46, Kasper Lund wrote:
> This is now empty. Should we get rid of this file completely?

Yes, we should. Thanks.

Expand Messages | Collapse Messages