Issue 3828015: Allow build of shim

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3828015: Allow build of shim (Closed)

Created:
10 years, 2 months ago by Nick Sanders

Modified:
9 years, 7 months ago

Reviewers:
djmm, David McMahon

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
ssh://git@gitrw.chromium.org:9222/crosutils.git

Visibility:
Public.

Description

Allow build of shim BUG=4547 TEST="run archive build" Change-Id: I716fbd2f648b8e5137ee515aaed7be89a6af8f37

Patch Set 1 #

Patch Set 2 : more commetns #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -20 lines)			Patch
	M	archive_build.sh	View	1	4 chunks	+41 lines, -20 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Nick Sanders

This should allow factory install shims to be built on buildbot. This is unlikely to ...

10 years, 2 months ago (2010-10-19 08:28:23 UTC) #1

anush

Dont want to hinder this CL, but archive_build.sh isn't the place we should be building ...

10 years, 2 months ago (2010-10-22 04:42:03 UTC) #4

Nick Sanders

10 years, 2 months ago (2010-10-22 08:57:38 UTC) #5

Totally agree. However all the test stuff and dev stuff are currently built
in archive build,
and there's no other way to put the shim in without major rewrites. Djmm and
I are assuming Chromite will fix this.

On Thu, Oct 21, 2010 at 9:41 PM, Anush Elangovan(அனுஷ்)
<anush@chromium.org>wrote:

> Dont want to hinder this CL, but archive_build.sh isn't the place we should
> be building anything. If we want we should add another step to buildbots.
>
> This sets the precedent for the next image type to be built (xxx_shim or
> xxx_installer) in archive_build.
>
>
> On Wed, Oct 20, 2010 at 11:20 AM, <djmm@google.com> wrote:
>
>> LGTM
>>
>>
>> http://codereview.chromium.org/3828015/show
>>
>
>

Expand Messages | Collapse Messages