Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(572)

Issue 3828009: Move scoped_nsdisable_screen_update from base to app/mac... (Closed)

Created:
10 years, 2 months ago by brettw
Modified:
9 years, 7 months ago
CC:
chromium-reviews, ben+cc_chromium.org, brettw-cc_chromium.org, pam+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Move scoped_nsdisable_screen_update from base to app/mac Move scoped_aedesc from base to base/mac Use namespace and proper Google-style class naming. TEST=it compiles BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=62904

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -303 lines) Patch
M app/app_base.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
A + app/mac/scoped_nsdisable_screen_updates.h View 1 2 chunks +8 lines, -7 lines 0 comments Download
M app/test_suite.h View 2 chunks +2 lines, -2 lines 0 comments Download
M base/base.gypi View 1 2 chunks +3 lines, -4 lines 0 comments Download
M base/chrome_application_mac.h View 1 1 chunk +1 line, -1 line 0 comments Download
A + base/mac/scoped_aedesc.h View 2 chunks +15 lines, -9 lines 0 comments Download
A + base/mac/scoped_nsautorelease_pool.h View 3 chunks +6 lines, -4 lines 0 comments Download
A + base/mac/scoped_nsautorelease_pool.mm View 2 chunks +4 lines, -2 lines 0 comments Download
M base/message_pump_default.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/message_pump_libevent.cc View 3 chunks +3 lines, -3 lines 0 comments Download
D base/scoped_aedesc.h View 1 1 chunk +0 lines, -47 lines 0 comments Download
D base/scoped_nsautorelease_pool.h View 1 1 chunk +0 lines, -53 lines 0 comments Download
D base/scoped_nsautorelease_pool.mm View 1 chunk +0 lines, -30 lines 0 comments Download
D base/scoped_nsdisable_screen_updates.h View 1 1 chunk +0 lines, -36 lines 0 comments Download
M base/shared_memory_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M base/test/test_suite.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/worker_pool_mac.mm View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/app/breakpad_mac.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/app/chrome_dll_main.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/browser_main.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/cocoa/bookmarks/bookmark_bubble_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/cocoa/bookmarks/bookmark_folder_target_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/cocoa/browser_frame_view.mm View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/cocoa/browser_window_controller.mm View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/cocoa/cocoa_test_helper.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/cocoa/cocoa_test_helper.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/cocoa/content_exceptions_window_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/cocoa/html_dialog_window_controller_unittest.mm View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/cocoa/install_from_dmg.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/cocoa/keyword_editor_cocoa_controller_unittest.mm View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/cocoa/preferences_window_controller.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/cocoa/tabpose_window_unittest.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/cocoa/web_drop_target_unittest.mm View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/dom_ui/options/advanced_options_utils_mac.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/geolocation/wifi_data_provider_corewlan_mac.mm View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/platform_util_mac.mm View 1 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view_mac.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/main_function_params.h View 1 chunk +5 lines, -3 lines 0 comments Download
M chrome/common/sandbox_mac.mm View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/renderer/renderer_main.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/in_process_browser_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/pyautolib/pyautolib.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/test_launcher/out_of_proc_test_runner.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/unit/chrome_test_suite.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/tools/mac_helpers/infoplist_strings_util.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M gfx/test_suite.h View 2 chunks +2 lines, -2 lines 0 comments Download
M gpu/command_buffer/client/cmd_buffer_helper_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M gpu/command_buffer/client/fenced_allocator_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M gpu/command_buffer/client/mapped_memory_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M gpu/command_buffer/client/ring_buffer_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/command_buffer_service_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M gpu/command_buffer/service/gpu_processor_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M remoting/host/simple_host_process.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M testing/gtest_mac_unittest.mm View 3 chunks +5 lines, -5 lines 0 comments Download
M webkit/tools/test_shell/run_all_tests.cc View 3 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
brettw
TBR
10 years, 2 months ago (2010-10-18 02:44:55 UTC) #1
Scott Hess - ex-Googler
LGTM for moving the specific files around. I think that base::mac:: namespace veers towards Hungarian ...
10 years, 2 months ago (2010-10-18 13:24:30 UTC) #2
brettw
10 years, 2 months ago (2010-10-18 15:53:21 UTC) #3
On Mon, Oct 18, 2010 at 6:24 AM,  <shess@chromium.org> wrote:
> LGTM for moving the specific files around.
>
> I think that base::mac:: namespace veers towards Hungarian notation in terms
> of
> pedantry, since the vast majority of uses are in mac-specific code anyhow.
>  Do
> we really need to go there?

Yeah, I kind of agree. There are definitely some cases where it helps.
ScopedNSAutoreleasePool is nice because it's actually used on other
platforms (as a NOP) and seeing the mac namespace there I think is
helpful in seeing what it's for. There were a couple of classes on the
Windows side that it helped as well. Plus, I'm hoping to kill all the
mac/win/etc_util.h files and put them in the platform directories with
actually descriptive filenames for what they are. I plan to just use
free-floating functions in the base::*:: namespace rather than
win_util::.

In the end, I'm hoping that being consistent with the naming,
directory structure, and namespace will pay off overall even though
there will be a few common cases that look stupid.

Brett

Powered by Google App Engine
This is Rietveld 408576698