Issue 3825001: Added USE_SIMULATOR macro that explicitly indicates that we wish to use the s...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3825001: Added USE_SIMULATOR macro that explicitly indicates that we wish to use the s... (Closed)

Created:
10 years, 2 months ago by marklam

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Added USE_SIMULATOR macro that explicitly indicates that we wish to use the simulator as the execution engine. For example, this allows us to run with the ARM simulator on ARM. Committed: http://code.google.com/p/v8/source/detail?r=5620

Patch Set 1 #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -13 lines)			Patch
M	SConstruct	View	2 chunks	+4 lines, -2 lines	0 comments	Download
M	src/arm/simulator-arm.h	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/arm/simulator-arm.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/mips/simulator-mips.h	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/mips/simulator-mips.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/v8.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

10 years, 2 months ago (2010-10-14 11:42:42 UTC) #2

On 2010/10/14 09:29:39, marklam wrote:
> Søren, can you review this change please?  Thanks.

LGTM. Committed r5620. Closing issue.

Expand Messages | Collapse Messages