Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Issue 3817011: Isolate depot_tools update into a separate script. (Closed)

Created:
10 years, 2 months ago by Mandeep Singh Baines
Modified:
9 years, 7 months ago
Reviewers:
M-A Ruel, Evan Martin
CC:
chromium-reviews, M-A Ruel
Visibility:
Public.

Description

Isolate depot_tools update into a separate script. Also, modify git-cl to also update depot_tools. Otherwise, the git-cl script never gets updated for folks that only use git-cl but not gclient. This fixes a bug ChromiumOS developers are currently seeing where there git-cl checkout is still pointing to src.chromium.org and not git.chromium.org. BUG=none TEST=Verified that git-cl help and gclient help work. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=62948

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -61 lines) Patch
M gclient View 1 chunk +1 line, -61 lines 0 comments Download
M git-cl View 1 chunk +2 lines, -0 lines 0 comments Download
A update_depot_tools View 1 chunk +68 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mandeep Singh Baines
10 years, 2 months ago (2010-10-18 17:56:22 UTC) #1
M-A Ruel
10 years, 2 months ago (2010-10-18 18:01:59 UTC) #2
My only issue is that will slow down git-cl even more. :(

That would have solved all the issues this morning so lgtm.

Powered by Google App Engine
This is Rietveld 408576698