Issue 3815007: Don't define USE_HEAPCHECKER on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3815007: Don't define USE_HEAPCHECKER on Windows. (Closed)

Created:
10 years, 2 months ago by Lei Zhang

Modified:
9 years, 7 months ago

Reviewers:
Alexander Potapenko

CC:
chromium-reviews, Timur Iskhodzhanov

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Don't define USE_HEAPCHECKER on Windows. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=62780

Patch Set 1 #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	build/build_config.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

It looks like we don't ever enable Heapchecker on Windows, so let's make USE_HEAPCHECKER reflect ...

10 years, 2 months ago (2010-10-15 03:01:16 UTC) #1

Alexander Potapenko

10 years, 2 months ago (2010-10-15 08:12:36 UTC) #2

LGTM, thanks!

On Fri, Oct 15, 2010 at 7:01 AM,  <thestig@chromium.org> wrote:
> Reviewers: Alexander Potapenko,
>
> Message:
> It looks like we don't ever enable Heapchecker on Windows, so let's make
> USE_HEAPCHECKER reflect that.
>
> I was trying to use USE_HEAPCHECKER and accidentally caused a lot of
> redness.
> Hopefully I can un-revert http://codereview.chromium.org/3779008/show
>
> Description:
> Don't define USE_HEAPCHECKER on Windows.
>
> BUG=none
> TEST=none
>
> Please review this at http://codereview.chromium.org/3815007/show
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>  M     build/build_config.h
>
>
> Index: build/build_config.h
> ===================================================================
> --- build/build_config.h        (revision 62695)
> +++ build/build_config.h        (working copy)
> @@ -66,7 +66,7 @@
>  #endif
>
>  // Use heapchecker.
> -#if (defined(OS_WIN) || defined(OS_LINUX)) && !defined(NO_HEAPCHECKER)
> +#if defined(OS_LINUX) && !defined(NO_HEAPCHECKER)
>  #define USE_HEAPCHECKER 1
>  #endif
>
>
>
>

Expand Messages | Collapse Messages