Increase the width for 'date-container' in download.html to 110px to make roo...

1. Increase the width for 'date-container' in download.html to 110px to make room for dates in some languages. Increase the margin-left (LTR) and margin-rigth(RTL) accordingly. 

2. Decrease the web font size (dom UI font size) for Bengali on Vista or later to 84% (the same value as used for English) while using 110% for XP. This is done by introducing a new 'string' (IDS_WEB_FONT_SIZE_XP) on Windows (other platforms won't get this). 


BUG=21699
TEST=Run Chrome with '--lang=ml' (--lang=kn, --lang=bn) on Windows and go to the download page. Make sure that dates are in a single line. 



Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35908

[jungshik at Google, 2009-11-16 23:28:35]

If 120 px is too large for other languages, an alternative is to do it for only
these 3 languages with a pseudo-lang selector.

[jungshik at Google, 2009-11-17 01:29:19]

Glen, I attached a screenshot to the bug. Can you take a look? I'm afraid it's
too wide for English.

[arv (Not doing code reviews), 2009-11-17 01:47:47]

LGTM

My only concern is the font size change. Does this affect NTP and other things?
Do they look OK with this smaller size?

[jungshik at Google, 2009-11-17 06:31:19]

On 2009/11/17 01:47:47, arv wrote:
> LGTM
> 
> My only concern is the font size change. Does this affect NTP and other
things?
> Do they look OK with this smaller size?

On Vista, it's better than now (it's too large at the moment). On XP, it may be
a bit small. I'll test my build on XP.

[jungshik at Google, 2009-11-17 22:59:17]

On 2009/11/17 06:31:19, Jungshik Shin wrote:
> On 2009/11/17 01:47:47, arv wrote:
> > LGTM
> > 
> > My only concern is the font size change. Does this affect NTP and other
> things?
> > Do they look OK with this smaller size?
> 
> On Vista, it's better than now (it's too large at the moment). On XP, it may
be
> a bit small. I'll test my build on XP.

MS changed the size of the default Bengali font on Vista. It's much larger (for
the same size requested) on Vista than on XP. They also changed the metrics for
some other Indian fonts, but not as much as the Bengali one. With 95%, Bengali
Chrome's dom UI looks a bit small (it's readable, but certainly small).  With
100%, it's better size-wise, but date container is not large enough (if it's
120px) on Vista.

We can introduce IDS_WEB_FONT_SIZE_WINXP and use the value only on XP.  (we
already do that for the Chrome's UI fonts due to this font-metric difference
between XP and Vista or later).

[jungshik at Google, 2009-11-17 23:10:28]

On 2009/11/17 22:59:17, Jungshik Shin wrote:

> With 95%, Bengali
> Chrome's dom UI looks a bit small (it's readable, but certainly small).  >
With
> 100%, it's better size-wise,

The above is on XP. On Vista, both look comfortably large. 

> but date container is not large enough (if it's
> 120px) on Vista.
>

[jungshik at Google, 2010-01-05 23:32:22]

arv and glen,

can you take another look? I introduced IDS_WEB_FONT_SIZE_XP to take care of a
rather drastic change in the font size between XP and Vista/Win7 for Bengali. In
addition, I used 110px for date container rather than 120px. Because even 120px
was Ok'd by Brian and Ben in the bug (which I missed completely by only looking
at the review page), a smaller value (110px) should be fine, too.

Once approved for the trunk, I  also like to take this to 249 branch.

[Glen Murphy, 2010-01-08 16:57:02]

LGTM

[arv (Not doing code reviews), 2010-01-08 17:38:50]

Still LGTM