Issue 3809005: Moves instant back into flags.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3809005: Moves instant back into flags. (Closed)

Created:
10 years, 2 months ago by sky

Modified:
9 years, 7 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, finnur+watch_chromium.org, ben+cc_chromium.org, Erik does not do reviews, Aaron Boodman, darin-cc_chromium.org, brettw-cc_chromium.org, pam+watch_chromium.org

Base URL:
http://git.chromium.org/git/chromium.git

Visibility:
Public.

Description

Moves instant back into flags. I'm TBRing this since it's mostly a revert. TBR=ben@chromium.org BUG=59298 TEST=make sure instant isn't in preferences anymore. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=62881

Patch Set 1 #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+25 lines, -102 lines)			Patch
M	chrome/app/generated_resources.grd	View	2 chunks	+2 lines, -8 lines	0 comments	Download
M	chrome/browser/about_flags.cc	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	chrome/browser/browser.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/browser.cc	View	3 chunks	+1 line, -11 lines	0 comments	Download
M	chrome/browser/instant/instant_controller.h	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	chrome/browser/instant/instant_controller.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/renderer_host/browser_render_process_host.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
	chrome/browser/views/options/general_page_view.h	View	4 chunks	+2 lines, -9 lines	0 comments	Download
M	chrome/browser/views/options/general_page_view.cc	View	9 chunks	+1 line, -60 lines	0 comments	Download
M	chrome/browser/views/options/options_group_view.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/views/options/options_group_view.cc	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/renderer/search_extension.cc	View	1 chunk	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

On 2010/10/15 21:49:46, sky wrote:
> 

ok

Expand Messages | Collapse Messages