Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(835)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: build/common.gypi

Issue 3807005: Revert 62604 - Use the correct flag for virtual destructor.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
===================================================================
--- build/common.gypi (revision 62608)
+++ build/common.gypi (working copy)
@@ -874,7 +874,7 @@
# Make inline functions have hidden visiblity by default.
# Surprisingly, not covered by -fvisibility=hidden.
'-fvisibility-inlines-hidden',
- '-Wnon-virtual-dtor',
+ '-Wno-non-virtual-dtor',
],
'ldflags': [
'-pthread', '-Wl,-z,noexecstack',
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698