Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 3806005: FBTF: More ctor/dtor cleanup. (Closed)

Created:
10 years, 2 months ago by Elliot Glaysher
Modified:
9 years, 7 months ago
CC:
chromium-reviews, michaeln, cbentzel+watch_chromium.org, ben+cc_chromium.org, brettw-cc_chromium.org, jam, darin-cc_chromium.org, Paweł Hajdan Jr., stuartmorgan+watch_chromium.org
Visibility:
Public.

Description

FBTF: More ctor/dtor cleanup. (3.5 megs off debug linux .a files) BUG=none TEST=compiles Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=62654

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+165 lines, -53 lines) Patch
M base/crypto/rsa_private_key.h View 1 chunk +3 lines, -1 line 0 comments Download
M base/crypto/rsa_private_key.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M base/vlog.h View 1 chunk +1 line, -0 lines 0 comments Download
M base/vlog.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/appcache/view_appcache_internals_job_factory.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/browser_process.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/browser_process.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/debugger/devtools_netlog_observer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/history/history_types.h View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/history/history_types.cc View 2 chunks +18 lines, -9 lines 0 comments Download
M chrome/browser/history/top_sites.cc View 2 chunks +8 lines, -10 lines 0 comments Download
M chrome/browser/history/top_sites_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/io_thread.h View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/io_thread.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/net/view_blob_internals_job_factory.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/net.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M net/server/http_server_request_info.h View 1 chunk +2 lines, -1 line 0 comments Download
A net/server/http_server_request_info.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M webkit/database/databases_table.h View 1 chunk +2 lines, -1 line 0 comments Download
M webkit/database/databases_table.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M webkit/fileapi/file_system_quota.h View 1 chunk +3 lines, -1 line 0 comments Download
M webkit/fileapi/file_system_quota.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M webkit/glue/plugins/plugin_group_unittest.cc View 2 chunks +17 lines, -23 lines 0 comments Download
M webkit/glue/plugins/webplugininfo.h View 2 chunks +13 lines, -0 lines 0 comments Download
A webkit/glue/plugins/webplugininfo.cc View 1 chunk +44 lines, -0 lines 0 comments Download
M webkit/glue/webkit_glue.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Elliot Glaysher
10 years, 2 months ago (2010-10-14 21:21:53 UTC) #1
James Hawkins
10 years, 2 months ago (2010-10-14 21:28:34 UTC) #2 
LGTM

Powered by Google App Engine
This is Rietveld 408576698