Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 3801013: Move APSL code into third_party. (Closed)

Created:
10 years, 2 months ago by Avi (use Gerrit)
Modified:
9 years, 7 months ago
CC:
chromium-reviews, ben+cc_chromium.org, arv (Not doing code reviews), pam+watch_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Move APSL code into third_party. BUG=none TEST=unit tested Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=62983

Patch Set 1 #

Total comments: 5

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+859 lines, -63 lines) Patch
M base/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M base/process_util_mac.mm View 1 4 chunks +8 lines, -63 lines 0 comments Download
M chrome/browser/resources/about_credits.html View 1 2 3 1 chunk +337 lines, -0 lines 0 comments Download
A third_party/apple_apsl/CFBase.h View 1 chunk +55 lines, -0 lines 0 comments Download
A third_party/apple_apsl/CFRuntime.h View 1 1 chunk +44 lines, -0 lines 0 comments Download
A third_party/apple_apsl/LICENSE View 1 2 3 1 chunk +327 lines, -0 lines 0 comments Download
A third_party/apple_apsl/README.chromium View 1 1 chunk +32 lines, -0 lines 0 comments Download
A third_party/apple_apsl/malloc.h View 1 1 chunk +55 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Avi (use Gerrit)
Mark: Code changes Danny: The approach
10 years, 2 months ago (2010-10-18 20:23:07 UTC) #1
Mark Mentovai
http://codereview.chromium.org/3801013/diff/1/2 File base/process_util_mac.mm (right): http://codereview.chromium.org/3801013/diff/1/2#newcode33 base/process_util_mac.mm:33: #include "third_party/apple_apsl/malloc.h" Sort. http://codereview.chromium.org/3801013/diff/1/4 File third_party/apple_apsl/CFBase.c (right): http://codereview.chromium.org/3801013/diff/1/4#newcode1 third_party/apple_apsl/CFBase.c:1: ...
10 years, 2 months ago (2010-10-18 20:28:47 UTC) #2
Avi (use Gerrit)
Addressed all of Mark's complaints.
10 years, 2 months ago (2010-10-18 20:42:21 UTC) #3
Mark Mentovai
Add CFBase.h to this change.
10 years, 2 months ago (2010-10-18 20:48:05 UTC) #4
Avi (use Gerrit)
Oops. Now there.
10 years, 2 months ago (2010-10-18 20:52:24 UTC) #5
Mark Mentovai
LGTM
10 years, 2 months ago (2010-10-18 20:59:09 UTC) #6
Avi (use Gerrit)
Added DEPS
10 years, 2 months ago (2010-10-18 21:47:33 UTC) #7
Mark Mentovai
LGTM
10 years, 2 months ago (2010-10-18 21:48:39 UTC) #8
Daniel Berlin
10 years, 2 months ago (2010-10-18 23:04:44 UTC) #9
LGTM

Powered by Google App Engine
This is Rietveld 408576698