Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: chrome/browser/extensions/extension_event_router.cc

Issue 3801008: Expands the chrome.experimental.processes extension API. ... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_event_router.cc
===================================================================
--- chrome/browser/extensions/extension_event_router.cc (revision 62984)
+++ chrome/browser/extensions/extension_event_router.cc (working copy)
@@ -7,6 +7,8 @@
#include "base/values.h"
#include "chrome/browser/child_process_security_policy.h"
#include "chrome/browser/extensions/extension_devtools_manager.h"
+#include "chrome/browser/extensions/extension_processes_api.h"
+#include "chrome/browser/extensions/extension_processes_api_constants.h"
#include "chrome/browser/extensions/extension_tabs_module.h"
#include "chrome/browser/profile.h"
#include "chrome/browser/renderer_host/render_process_host.h"
@@ -62,6 +64,11 @@
extension_devtools_manager_->AddEventListener(event_name,
render_process_id);
}
+
+ // We lazily tell the TaskManager to start updating when listeners to the
+ // processes.onUpdated event arrive.
+ if (event_name.compare(extension_processes_api_constants::kOnUpdated) == 0)
+ ExtensionProcessesEventRouter::GetInstance()->ListenerAdded();
}
void ExtensionEventRouter::RemoveEventListener(
@@ -75,6 +82,11 @@
extension_devtools_manager_->RemoveEventListener(event_name,
render_process_id);
}
+
+ // If a processes.onUpdated event listener is removed (or a process with one
+ // exits), then we let the TaskManager know that it has one fewer listener.
+ if (event_name.compare(extension_processes_api_constants::kOnUpdated) == 0)
+ ExtensionProcessesEventRouter::GetInstance()->ListenerRemoved();
}
bool ExtensionEventRouter::HasEventListener(const std::string& event_name) {
Property changes on: chrome/browser/extensions/extension_event_router.cc
___________________________________________________________________
Added: svn:eol-style
+ LF
« no previous file with comments | « chrome/browser/cocoa/task_manager_mac_unittest.mm ('k') | chrome/browser/extensions/extension_function_dispatcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698