Issue 38009: Move GdkPixbufFromSkBitmap to gtk_util so it can easily be shared.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 38009: Move GdkPixbufFromSkBitmap to gtk_util so it can easily be shared. (Closed)

Created:
11 years, 9 months ago by Dean McNamee

Modified:
9 years, 7 months ago

Reviewers:
Evan Martin, Evan Stade

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Move GdkPixbufFromSkBitmap to gtk_util so it can easily be shared.

Patch Set 1 #

Total comments: 1

Patch Set 2 : Merge / warning #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -40 lines)			Patch
M	base/gfx/gtk_util.h	View	1	2 chunks	+5 lines, -0 lines	0 comments	Download
M	base/gfx/gtk_util.cc	View		2 chunks	+39 lines, -0 lines	0 comments	Download
M	chrome/browser/gtk/menu_gtk.cc	View	1	3 chunks	+2 lines, -40 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

11 years, 9 months ago (2009-03-09 18:49:57 UTC) #3

LG

http://codereview.chromium.org/38009/diff/1/3
File base/gfx/gtk_util.h (right):

http://codereview.chromium.org/38009/diff/1/3#newcode21
Line 21: // Convert and copy a SkBitmap to a GdkPixbuf.
Perhaps note that this is expensive and slow, due to byte-swapping.

Expand Messages | Collapse Messages