Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Issue 380007: Clean up recent string conversion function changes, part 1: Remove unnecessar... (Closed)

Created:
11 years, 1 month ago by Peter Kasting
Modified:
9 years, 7 months ago
Reviewers:
brettw
CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, darin (slow to review), Paweł Hajdan Jr.
Visibility:
Public.

Description

Clean up recent string conversion function changes, part 1: Remove unnecessary code. Thanks to a change in escape.cc I can basically revert the ICU conversions back to what they used to be; I can also get rid of half the conversions immediately since they aren't used. This does not split out the "adjust" versions of the UTF conversions into their own header/implementation; that's coming in the next patch. BUG=4010 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=31533

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -260 lines) Patch
M base/i18n/icu_string_conversions.h View 3 chunks +8 lines, -36 lines 0 comments Download
M base/i18n/icu_string_conversions.cc View 6 chunks +16 lines, -88 lines 0 comments Download
M base/i18n/icu_string_conversions_unittest.cc View 1 chunk +0 lines, -41 lines 0 comments Download
M base/utf_string_conversions.h View 4 chunks +4 lines, -26 lines 0 comments Download
M base/utf_string_conversions.cc View 3 chunks +10 lines, -30 lines 0 comments Download
M base/utf_string_conversions_unittest.cc View 2 chunks +1 line, -35 lines 0 comments Download
M net/base/escape.cc View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Peter Kasting
Note: I removed the comments above the ICU function definitions because Scott pointed out in ...
11 years, 1 month ago (2009-11-09 23:56:45 UTC) #1
brettw
11 years, 1 month ago (2009-11-10 01:11:26 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698