chrome/browser/metrics/metrics_service.cc - Issue 3800003: Moving GUID generation from base to chrome/browser/guid*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/metrics/metrics_service.cc

Issue 3800003: Moving GUID generation from base to chrome/browser/guid* (Closed)

Patch Set: Additional comment. Created 10 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/metrics/metrics_service.cc

diff --git a/chrome/browser/metrics/metrics_service.cc b/chrome/browser/metrics/metrics_service.cc

index 2687eba74d29c3c02c720b49ca087521992a985b..37b79b7662d7904479ab777259731655dc182d8e 100644

--- a/chrome/browser/metrics/metrics_service.cc

+++ b/chrome/browser/metrics/metrics_service.cc

@@ -162,7 +162,6 @@

#include "base/command_line.h"

#include "base/md5.h"

#include "base/metrics/histogram.h"

-#include "base/rand_util.h"

#include "base/string_number_conversions.h"

#include "base/thread.h"

#include "base/utf_string_conversions.h"

@@ -170,6 +169,7 @@

#include "chrome/browser/bookmarks/bookmark_model.h"

#include "chrome/browser/browser_list.h"

#include "chrome/browser/browser_process.h"

+#include "chrome/browser/guid.h"

#include "chrome/browser/load_notification_details.h"

#include "chrome/browser/memory_details.h"

#include "chrome/browser/metrics/histogram_synchronizer.h"

@@ -808,7 +808,7 @@ void MetricsService::OnInitTaskComplete(

}

std::string MetricsService::GenerateClientID() {

- return base::GenerateGUID();

+ return guid::GenerateGUID();

}

//------------------------------------------------------------------------------

« no previous file with comments | « chrome/browser/guid_win.cc ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »