Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3693)

Unified Diff: chrome/browser/cocoa/preferences_window_controller.mm

Issue 3798001: Merge 62408 - Fixes bugs in usage of adding a new tab with a disposition of... (Closed) Base URL: svn://svn.chromium.org/chrome/branches/552/src/
Patch Set: Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/cocoa/preferences_window_controller.mm
===================================================================
--- chrome/browser/cocoa/preferences_window_controller.mm (revision 62416)
+++ chrome/browser/cocoa/preferences_window_controller.mm (working copy)
@@ -45,6 +45,7 @@
#include "chrome/browser/profile.h"
#include "chrome/browser/safe_browsing/safe_browsing_service.h"
#include "chrome/browser/shell_integration.h"
+#include "chrome/browser/show_options_url.h"
#include "chrome/browser/sync/profile_sync_service.h"
#include "chrome/browser/sync/sync_ui_util.h"
#include "chrome/browser/tab_contents/tab_contents.h"
@@ -1488,17 +1489,15 @@
- (IBAction)privacyLearnMore:(id)sender {
// We open a new browser window so the Options dialog doesn't get lost
// behind other windows.
- Browser* browser = Browser::Create(profile_);
- browser->OpenURL(GURL(l10n_util::GetStringUTF16(IDS_LEARN_MORE_PRIVACY_URL)),
- GURL(), NEW_WINDOW, PageTransition::LINK);
+ browser::ShowOptionsURL(
+ profile_,
+ GURL(l10n_util::GetStringUTF16(IDS_LEARN_MORE_PRIVACY_URL)));
}
- (IBAction)backgroundModeLearnMore:(id)sender {
- // We open a new browser window so the Options dialog doesn't get lost
- // behind other windows.
- Browser::Create(profile_)->OpenURL(
- GURL(l10n_util::GetStringUTF16(IDS_LEARN_MORE_BACKGROUND_MODE_URL)),
- GURL(), NEW_WINDOW, PageTransition::LINK);
+ browser::ShowOptionsURL(
+ profile_,
+ GURL(l10n_util::GetStringUTF16(IDS_LEARN_MORE_BACKGROUND_MODE_URL)));
}
- (IBAction)resetAutoOpenFiles:(id)sender {
« no previous file with comments | « chrome/browser/cocoa/about_window_controller.mm ('k') | chrome/browser/gtk/options/advanced_contents_gtk.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698