Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(668)

Issue 3797014: Add a flag to control deb-srcs and only add host bins to the chroot if the distro matches. (Closed)

Created:
10 years, 2 months ago by Michael Moss
Modified:
9 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Add a flag to control deb-srcs and only add host bins to the chroot if the distro matches. This fixes a problem on the Chrome buildbots where installing a hardy32 chroot on a lucid64 machine results in 'ld' and other files in the chroot which do not work because glibc is too old, and also prevents problems with apt-get fetching from custom mirrors without source packages. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=63175

Patch Set 1 #

Patch Set 2 : review change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -6 lines) Patch
M build/install-chroot.sh View 1 5 chunks +22 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Michael Moss
10 years, 2 months ago (2010-10-18 19:52:53 UTC) #1
Markus (顧孟勤)
Can you make the copying of ld and gdb a command line option? There are ...
10 years, 2 months ago (2010-10-18 20:42:31 UTC) #2
Michael Moss
OK, it will only automatically copy the 64bit bins when the chroot distro matches the ...
10 years, 2 months ago (2010-10-20 02:25:44 UTC) #3
nsylvain
lgtm ;)
10 years, 2 months ago (2010-10-20 02:42:28 UTC) #4
Markus (顧孟勤)
10 years, 2 months ago (2010-10-20 06:17:37 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld 408576698