Issue 3796008: Fixed some logic bugs in the Network Menu DOM UI (7343)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3796008: Fixed some logic bugs in the Network Menu DOM UI (7343) (Closed)

Created:
10 years, 2 months ago by stevenjb

Modified:
9 years, 7 months ago

Reviewers:
xiyuan, oshima_google, oshima

CC:
chromium-reviews, davemoore+watch_chromium.org, ben+cc_chromium.org

Visibility:
Public.

Fixed some network menu logic bugs. Also modified NetworkMenu::ActivatedAt to use ConnectToNetworkAt() to reduce duplicated logic. BUG=chromium-os:7343 TEST=Test network menu Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=62822

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+128 lines, -71 lines)			Patch
M	chrome/browser/chromeos/dom_ui/network_menu_ui.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/dom_ui/network_menu_ui.cc	View	4 chunks	+31 lines, -8 lines	0 comments	Download
M	chrome/browser/chromeos/status/network_menu.h	View	2 chunks	+12 lines, -3 lines	0 comments	Download
M	chrome/browser/chromeos/status/network_menu.cc	View	9 chunks	+83 lines, -59 lines	0 comments	Download

Total messages: 4 (0 generated)

stevenjb

This should make the network menu functional again. Please review as soon as you can. ...

10 years, 2 months ago (2010-10-15 21:47:27 UTC) #1

oshima_google

lgtm btw, when are we going to remove old options view?

10 years, 2 months ago (2010-10-15 21:55:52 UTC) #3

oshima

10 years, 2 months ago (2010-10-15 21:56:28 UTC) #4

oops, wrong account LGTM with same comment.

On 2010/10/15 21:55:52, oshima1 wrote:
> lgtm
> 
> btw, when are we going to remove old options view?