tag_image.sh: support more tags

scripts/image_signing/tag_image.sh

 #!/bin/bash
 
 # Copyright (c) 2010 The Chromium OS Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # Script to manipulate the tag files in the output of build_image
 
 # Load common constants.  This should be the first executable line.
 # The path to common.sh should be relative to your script's location.
 . "$(dirname "$0")/common.sh"
 
 DEFINE_string from "chromiumos_image.bin" \
   "Input file name of Chrome OS image to tag/stamp."
+DEFINE_string dev_mode "" \
+  "(build-info) Tag as a developer mode build (1 to enable, 0 to disable)"
 DEFINE_string update_firmware "" \
-  "Tag to force updating firmware (1 to enable, 0 to disable)"
-DEFINE_string dev_mode "" \
-  "Tag for developer mode (1 to enable, 0 to disable)"
+  "(auto-update) Force updating firmware (1 to enable, 0 to disable)"
+DEFINE_string forget_usernames "" \
+  "(session-manager) Forget usernames (1 to enable, 0 to disable)"
+DEFINE_string leave_core "" \
+  "(crash-reporter) Leave core dumps (1 to enable, 0 to disable)"
+
+# TODO(hungte) we can add factory_installer and factory_test,
+# but I don't see any reason to tweak/check these values.
 
 # Parse command line
 FLAGS "$@" || exit 1
 eval set -- "${FLAGS_ARGV}"
 
 # Abort on error
 set -e
 
-if [ -z ${FLAGS_from} ] || [ ! -f ${FLAGS_from} ] ; then
-  echo "Error: invalid flag --from"
+if [ -z "${FLAGS_from}" ] || [ ! -s "${FLAGS_from}" ] ; then
+  echo "Error: need a valid file by --from"
   exit 1
 fi
 
 # Global variable to track if image is modified.
 g_modified=${FLAGS_FALSE}
 
 # Processes (enable, disable, or simply report) a tag file.
 # Args: DO_MODIFICATION NAME ROOT TAG_FILE ACTION
 #
 # When DO_MODIFICATION=${FLAGS_TRUE},
@@ skipping 66 matching lines @@
 
 # Iterates all tags to a given partition root.
 # Args: ROOTFS DO_MODIFICATION
 #
 # Check process_tag for the meaning of parameters.
 process_all_tags() {
   local rootfs="$1"
   local do_modification="$2"
 
   process_tag "${do_modification}" \
-    "Update Firmware" \
+    "(build-info) dev_mode" \
+    "${rootfs}" \
+    /root/.dev_mode \
+    "${FLAGS_dev_mode}"
+
+  process_tag "${do_modification}" \
+    "(auto-update) update_firmware" \
     "${rootfs}" \
     /root/.force_update_firmware \
     "${FLAGS_update_firmware}"
 
   process_tag "${do_modification}" \
-    "Developer Mode" \
+    "(session-manager) forget_usernames" \
     "${rootfs}" \
-    /root/.dev_mode \
-    "${FLAGS_dev_mode}"
+    /root/.forget_usernames \
+    "${FLAGS_forget_usernames}"
+
+  process_tag "${do_modification}" \
+    "(crash-reporter) leave_core" \
+    "${rootfs}" \
+    /root/.leave_core \
+    "${FLAGS_leave_core}"
 }
 
 IMAGE=$(readlink -f "${FLAGS_from}")
 if [[ -z "${IMAGE}" || ! -f "${IMAGE}" ]]; then
   echo "Missing required argument: --from (image to update)"
   usage
   exit 1
 fi
 
 # First round, mount as read-only and check if we read any modification.
@@ skipping 14 matching lines @@
   # Second round, apply the modification to image.
   process_all_tags "${rootfs}" ${FLAGS_TRUE}
 
   # this is supposed to be automatically done in mount_image_partition,
   # but it's no harm to explicitly make it again here.
   tag_as_needs_to_be_resigned "${rootfs}"
   echo "IMAGE IS MODIFIED. PLEASE REMEMBER TO RESIGN YOUR IMAGE."
 else
   echo "Image is not modified."
 fi