Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1001)

Unified Diff: chrome/browser/gtk/browser_actions_toolbar_gtk.cc

Issue 379020: Fix double delete of ImageLoadingTracker in BrowserActionButton. (Closed)
Patch Set: Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/gtk/browser_actions_toolbar_gtk.cc
diff --git a/chrome/browser/gtk/browser_actions_toolbar_gtk.cc b/chrome/browser/gtk/browser_actions_toolbar_gtk.cc
index 176b4eec52fa112dd70bef890fe3d674cb615dd1..fb36c0db76a301bca42e8793e03f167988cec541 100644
--- a/chrome/browser/gtk/browser_actions_toolbar_gtk.cc
+++ b/chrome/browser/gtk/browser_actions_toolbar_gtk.cc
@@ -105,6 +105,7 @@ class BrowserActionButton : public NotificationObserver,
void OnImageLoaded(SkBitmap* image, size_t index) {
if (image)
default_icon_ = gfx::GdkPixbufFromSkBitmap(image);
+ tracker_ = NULL; // The tracker object will delete itself when we return.
UpdateState();
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698