Issue 3789004: Fixed partner issue 1414: Failed to create dev_recovery_image.bin using dev install shim

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3789004: Fixed partner issue 1414: Failed to create dev_recovery_image.bin using dev install shim (Closed)

Created:
10 years, 2 months ago by dianders

Modified:
9 years, 7 months ago

Reviewers:
gauravsh-google, gauravsh

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
ssh://git@gitrw.chromium.org:9222/crosutils.git

Visibility:
Public.

Description

Fixed partner issue 1414: Failed to create dev_recovery_image.bin using dev install shim Change-Id: I69291bf29d68f9511d0618e55cabccee9904749b BUG=chrome-os-partner:1414 TEST=Ran the script Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=77b239b

Patch Set 1 #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -3 lines)			Patch
	M	mod_image_for_dev_recovery.sh	View		1 chunk	+2 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

gauravsh

lgtm really optional nitty nit: a statement about how your fix fixes things is always ...

10 years, 2 months ago (2010-10-14 23:28:32 UTC) #2

dianders

10 years, 2 months ago (2010-10-14 23:44:47 UTC) #3

OK, thanks.  Roughly, the problem showed up whenever "$(basename
${FLAGS_payload_dir})" was "dev_payload".  Thus, you ended up with:

  mv /tmp/xyz/dev_payload /tmp/xyz/dev_payload

...which is not good.  If the two weren't the same, though, you would have been
OK:

  mv /tmp/xyz/my_payload /tmp/xyz/dev_payload

I solved the problem by avoiding the extra "mv".  Instead, I just used the first
"mv" to give the folder the right name.

Thanks for the review!

On 2010/10/14 23:28:32, gauravsh wrote:
> lgtm
> 
> really optional nitty nit: a statement about how your fix fixes things is
always
> good.

Expand Messages | Collapse Messages