Issue 3785014: make_dev_firmware: provide more usage help for backup files

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3785014: make_dev_firmware: provide more usage help for backup files (Closed)

Created:
10 years, 2 months ago by Hung-Te

Modified:
9 years, 7 months ago

Reviewers:
Randall Spangler

CC:
chromium-os-reviews_chromium.org, Randall Spangler, gauravsh, Luigi Semenzato, Bill Richardson

Base URL:
ssh://git@gitrw.chromium.org:9222/vboot_reference.git

Visibility:
Public.

Description

make_dev_firmware: provide more usage help for backup files Provide more clear instruction on how to use the backup files, and to try more effort to store backup files BUG=none TEST=emerge-x86-generic vboot-reference; executed make_dev_firmware and got correct message Change-Id: I2062f45dd3019d0e56adc18bdd1861991aafe5ed Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=eb868ee

Patch Set 1 #

Total comments: 1

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -1 line)			Patch
	M	scripts/image_signing/make_dev_firmware.sh	View		1 chunk	+18 lines, -1 line	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Randall Spangler

10 years, 2 months ago (2010-10-18 15:34:31 UTC) #2

LGTM, thanks!

http://codereview.chromium.org/3785014/diff/1/2
File scripts/image_signing/make_dev_firmware.sh (right):

http://codereview.chromium.org/3785014/diff/1/2#newcode211
scripts/image_signing/make_dev_firmware.sh:211: # so that the only command to
remember would be make_dev_firmware.sh.
Good idea.

Expand Messages | Collapse Messages