Add a tag for removing crosh_workarounds. Also add options for manipulating /etc/lsb-release.

Add a tag for removing crosh_workarounds. Also add options for manipulating /etc/lsb-release.

Adds --crosh_workarounds (only removal is supported), --remove_test_label (for removing test in /etc/lsb-release) and --change_dev_to_beta (for changing "dev" -> "beta" in /etc/lsb-release)

BUG=chromium-os:5920
TEST=manual

Change-Id: Id4c94d76a6d8794a4d134790d0c2f5d4a336084f

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=cb844af

[Hung-Te, 2010-10-18 02:45:46]

http://codereview.chromium.org/3781012/diff/1/2
File scripts/image_signing/tag_image.sh (right):

http://codereview.chromium.org/3781012/diff/1/2#newcode165
scripts/image_signing/tag_image.sh:165: process_all_lsb_mods() {
If most lsb_mods can be captured by an sed script to change and a grep to search
for status, maybe we can create a process_sed DO_MODIFICATION NAME ROOT FILE
SED_COMMAND GREP_COMMAND

http://codereview.chromium.org/3781012/diff/1/2#newcode169
scripts/image_signing/tag_image.sh:169: g_modified=${FLAGS_TRUE}
g_modified was designed to indicate if we really need to perform a remount and
make changes. Can we add a check so that g_modified=TRUE only when test_label
exists (ex, grep test lsb-release)?

http://codereview.chromium.org/3781012/diff/1/2#newcode171
scripts/image_signing/tag_image.sh:171: sed -i 's/test//'
"${rootfs}/etc/lsb-release" && \
&& does not need the trailing backslash

http://codereview.chromium.org/3781012/diff/1/2#newcode171
scripts/image_signing/tag_image.sh:171: sed -i 's/test//'
"${rootfs}/etc/lsb-release" && \
I'm a little worried the the pattern here, since this may change any 'test' even
if it's part of a word, host name/url, HWID etc, like "brightest, contest,
secretest, shortest, ..."
Is there any example for how the 'test' would appear, and is there any better
rules like ' test ' or '=test '?

http://codereview.chromium.org/3781012/diff/1/2#newcode179
scripts/image_signing/tag_image.sh:179: sed -i 's/dev/beta/'
"${rootfs}/etc/lsb-release" && \
&& does not need the trailing backslash. Also 's/dev/beta/' sounds more
dangerous because 'dev' may appear in middle of many words, like "device,
devote, vaudeville, ..."

[gauravsh, 2010-10-18 19:21:45]

http://codereview.chromium.org/3781012/diff/1/2
File scripts/image_signing/tag_image.sh (right):

http://codereview.chromium.org/3781012/diff/1/2#newcode165
scripts/image_signing/tag_image.sh:165: process_all_lsb_mods() {
On 2010/10/18 02:45:46, Hung-Te wrote:
> If most lsb_mods can be captured by an sed script to change and a grep to
search
> for status, maybe we can create a process_sed DO_MODIFICATION NAME ROOT FILE
> SED_COMMAND GREP_COMMAND

Agree. However, I would wait on making that more general after we have a bunch
more lsb_mods and feel the need to consolidate.

http://codereview.chromium.org/3781012/diff/1/2#newcode169
scripts/image_signing/tag_image.sh:169: g_modified=${FLAGS_TRUE}
On 2010/10/18 02:45:46, Hung-Te wrote:
> g_modified was designed to indicate if we really need to perform a remount and
> make changes. Can we add a check so that g_modified=TRUE only when test_label
> exists (ex, grep test lsb-release)?

Done.

http://codereview.chromium.org/3781012/diff/1/2#newcode171
scripts/image_signing/tag_image.sh:171: sed -i 's/test//'
"${rootfs}/etc/lsb-release" && \
On 2010/10/18 02:45:46, Hung-Te wrote:
> I'm a little worried the the pattern here, since this may change any 'test'
even
> if it's part of a word, host name/url, HWID etc, like "brightest, contest,
> secretest, shortest, ..."
> Is there any example for how the 'test' would appear, and is there any better
> rules like ' test ' or '=test '?

It is usually in the form of a ' test ' in the release description field.
Frankly, the format in /etc/lsb-release is rather ad-hoc and in much in flux, so
I would much rather keep it simple for now and change to a more specific test
once the lsb-release is final.

I have changed it only look for "test" at word boundaries.

http://codereview.chromium.org/3781012/diff/1/2#newcode179
scripts/image_signing/tag_image.sh:179: sed -i 's/dev/beta/'
"${rootfs}/etc/lsb-release" && \
On 2010/10/18 02:45:46, Hung-Te wrote:
> && does not need the trailing backslash. Also 's/dev/beta/' sounds more
> dangerous because 'dev' may appear in middle of many words, like "device,
> devote, vaudeville, ..."

Done. Changed to only look for word boundaries.

[Hung-Te, 2010-10-19 01:36:20]

LGTM. Thanks!