Error when creating a CL in a read-only checkout....

Error when creating a CL in a read-only checkout.

BUG=25824
TEST=running 'gcl change foo' in a read-only checkout
shows an error, --force creates a CL anyway, and gcl
change in read-write checkouts continues to work.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=31452

[M-A Ruel, 2009-11-09 18:34:50]

http://codereview.chromium.org/378027/diff/1/2
File gcl.py (right):

http://codereview.chromium.org/378027/diff/1/2#newcode1003
Line 1003: if not re.match(r'^svn', svn_info['URL']) and not FilterFlag(args,
"--force"):
No, it would fail with https checkout and we don't want that to fail. Just
blacklist http:// instead.

[chase, 2009-11-09 18:38:06]

http://codereview.chromium.org/378027/diff/1/2
File gcl.py (right):

http://codereview.chromium.org/378027/diff/1/2#newcode1003
Line 1003: if not re.match(r'^svn', svn_info['URL']) and not FilterFlag(args,
"--force"):
On 2009/11/09 18:34:50, Marc-Antoine Ruel wrote:
> No, it would fail with https checkout and we don't want that to fail. Just
> blacklist http:// instead.

Done.

[M-A Ruel, 2009-11-09 18:44:28]

lgtm with this change

http://codereview.chromium.org/378027/diff/3001/4001
File gcl.py (right):

http://codereview.chromium.org/378027/diff/3001/4001#newcode1003
Line 1003: if re.match(r'^http:', svn_info['URL']) and not FilterFlag(args,
"--force"):
why not 
if (svn_info.get('URL', '').startswith('http:') and
    not FilterFlag(args, '--force')):

It may happen that URL is not defined and a regexp seems overkill.

[chase, 2009-11-09 18:47:30]

http://codereview.chromium.org/378027/diff/3001/4001
File gcl.py (right):

http://codereview.chromium.org/378027/diff/3001/4001#newcode1003
Line 1003: if re.match(r'^http:', svn_info['URL']) and not FilterFlag(args,
"--force"):
On 2009/11/09 18:44:28, Marc-Antoine Ruel wrote:
> why not 
> if (svn_info.get('URL', '').startswith('http:') and
>     not FilterFlag(args, '--force')):
> 
> It may happen that URL is not defined and a regexp seems overkill.

Done.

[M-A Ruel, 2009-11-09 18:51:41]

http://codereview.chromium.org/378027/diff/5002/2002
File gcl.py (right):

http://codereview.chromium.org/378027/diff/5002/2002#newcode1004
Line 1004: not FilterFlag(args, "--force")):
alignment