Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 378024: * Fix regexp benchmark regression where we were doing work to... (Closed)

Created:
11 years, 1 month ago by Erik Corry
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

* Fix regexp benchmark regression where we were doing work to make standard regexps like \s and . case independent. * Make use of the fact that the subject string is ASCII only when making character classes case independent. * Avoid spending time making large ideogram or punctuation ranges case independent when there is no case mapping anyway. Committed: http://code.google.com/p/v8/source/detail?r=3243

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+175 lines, -55 lines) Patch
M src/jsregexp.h View 4 chunks +7 lines, -4 lines 0 comments Download
M src/jsregexp.cc View 7 chunks +126 lines, -48 lines 1 comment Download
M test/cctest/test-regexp.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/cyrillic.js View 6 chunks +41 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Erik Corry
11 years, 1 month ago (2009-11-09 09:47:24 UTC) #1
Christian Plesner Hansen
11 years, 1 month ago (2009-11-09 09:56:52 UTC) #2
Lgtm.

http://codereview.chromium.org/378024/diff/1/5
File src/jsregexp.cc (right):

http://codereview.chromium.org/378024/diff/1/5#newcode2441
Line 2441: // None of the standard regexps is different in the case independent
case
s/regexps is/character classes are/

Powered by Google App Engine
This is Rietveld 408576698