Index: webkit/api/src/EditorClientImpl.cpp |
diff --git a/webkit/api/src/EditorClientImpl.cpp b/webkit/api/src/EditorClientImpl.cpp |
index bf67573ceb623c0e11071ed8289916b192d9e562..77c09fc166b189f3d0759e3e428e113cd2904ffc 100644 |
--- a/webkit/api/src/EditorClientImpl.cpp |
+++ b/webkit/api/src/EditorClientImpl.cpp |
@@ -360,6 +360,12 @@ static const unsigned MetaKey = 1 << 3; |
// Aliases for the generic key defintions to make kbd shortcuts definitions more |
// readable on OS X. |
static const unsigned OptionKey = AltKey; |
+ |
+// Do not use this constant for anything but cursor movement commands. Keys |
+// with cmd set have their |isSystemKey| bit set, so chances are the shortcut |
+// will not be executed. Another, less important, reason is that shortcuts |
+// defined in the renderer do not blink the menu item that they triggered. See |
+// http://crbug.com/25856 and the bugs linked from there for details. |
static const unsigned CommandKey = MetaKey; |
#endif |