Change KVM to use e1000

Change KVM to use e1000

add -net nic,model=e1000 in start_kvm and in the suggested command as
output by image_to_vm.sh

Signed-off-by: Olof Johansson <olofj@chromium.org>;

BUG=none
TEST=Boot an image, run lspci in a terminal, see intel nic

[Olof Johansson, 2010-10-14 23:10:23]

I have only been able to make manual test of this, since cros_run_vm_test
doesn't seem to work for me because of the inside/outside chroot issues. I did
see the guest come up with working ethernet though.

[sosa, 2010-10-14 23:20:46]

Is the support for e1000 recent?

On Thu, Oct 14, 2010 at 4:10 PM,  <olofj@chromium.org> wrote:
> Reviewers: sosa, rtc,
>
> Message:
> I have only been able to make manual test of this, since cros_run_vm_test
> doesn't seem to work for me because of the inside/outside chroot issues. I
> did
> see the guest come up with working ethernet though.
>
> Description:
> Change KVM to use e1000
>
> add -net nic,model=e1000 in start_kvm and in the suggested command as
> output by image_to_vm.sh
>
> Signed-off-by: Olof Johansson <olofj@chromium.org>
>
> BUG=none
> TEST=Boot an image, run lspci in a terminal, see intel nic
>
> Please review this at http://codereview.chromium.org/3779007/show
>
> SVN Base: ssh://git@gitrw.chromium.org:9222/crosutils.git
>
> Affected files:
>  M image_to_vm.sh
>  M lib/cros_vm_lib.sh
>
>
> Index: image_to_vm.sh
> diff --git a/image_to_vm.sh b/image_to_vm.sh
> index
>
d6ff61fa8b2edf6d1b139ab7ae40b35de84ee295..382d4ac763796ba116e032be3b00d027ce52c9e0
> 100755
> --- a/image_to_vm.sh
> +++ b/image_to_vm.sh
> @@ -280,7 +280,7 @@ fi
>
>  if [ "${FLAGS_format}" == "qemu" ]; then
>   echo "If you have qemu-kvm installed, you can start the image by:"
> -  echo "sudo kvm -m ${FLAGS_mem} -vga std -pidfile /tmp/kvm.pid -net nic "
> \
> +  echo "sudo kvm -m ${FLAGS_mem} -vga std -pidfile /tmp/kvm.pid -net
> nic,model=e1000 " \
>        "-net user,hostfwd=tcp::922-:22 \\"
>   echo "        -hda ${FLAGS_to}/${DEFAULT_QEMU_IMAGE}"
>  fi
> Index: lib/cros_vm_lib.sh
> diff --git a/lib/cros_vm_lib.sh b/lib/cros_vm_lib.sh
> index
>
f36804d378b4545c4398ec40f5a8e8977eec212f..1809acc9d13fd812e2ed6edc3b6ce63612c0595d
> 100644
> --- a/lib/cros_vm_lib.sh
> +++ b/lib/cros_vm_lib.sh
> @@ -51,7 +51,7 @@ function start_kvm() {
>       -vga std \
>       -pidfile "${KVM_PID_FILE}" \
>       -daemonize \
> -      -net nic \
> +      -net nic,model=e1000 \
>       ${nographics} \
>       ${snapshot} \
>       -net user,hostfwd=tcp::${FLAGS_ssh_port}-:22 \
>
>
>

[Olof Johansson, 2010-10-14 23:34:24]

On 2010/10/14 23:20:46, sosa wrote:
> Is the support for e1000 recent?

In KVM/qemu? Shouldn't be.

[sosa, 2010-10-14 23:41:44]

Tested locally here.  Works.

LGTM

On Thu, Oct 14, 2010 at 4:34 PM,  <olofj@chromium.org> wrote:
> On 2010/10/14 23:20:46, sosa wrote:
>>
>> Is the support for e1000 recent?
>
> In KVM/qemu? Shouldn't be.
>
> http://codereview.chromium.org/3779007/show
>