Issue 3778004: Restructure RegExp exec cache code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3778004: Restructure RegExp exec cache code. (Closed)

Created:
10 years, 2 months ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Visibility:
Public.

Description

Restructure RegExp exec cache code.

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed review comments. #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+176 lines, -66 lines)			Patch
M	src/regexp.js	View	1	6 chunks	+87 lines, -63 lines	0 comments	Download
M	src/string.js	View		2 chunks	+2 lines, -3 lines	0 comments	Download
M	test/mjsunit/regexp.js	View		1 chunk	+87 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

10 years, 2 months ago (2010-10-14 12:19:12 UTC) #2

I would still like a regression test.

Otherwise LGTM

http://codereview.chromium.org/3778004/diff/1/2
File src/regexp.js (right):

http://codereview.chromium.org/3778004/diff/1/2#newcode222
src/regexp.js:222: var i = TO_INTEGER(lastIndex);  // Conversion is required by
spec.
Paragraph and version?

http://codereview.chromium.org/3778004/diff/1/2#newcode328
src/regexp.js:328: if (%_StringCharCodeAt(this.source, 0) == 46 && // '.'
Should be 2 spaces before //

Expand Messages | Collapse Messages