Detect available lib64readline version before trying to install in chroot.

Detect available lib64readline version before trying to install in chroot.

This fixes a problem where creating a hardy32 chroot fails because the package
name used to be lib64readline5. Perhaps all the packages should be detected
like this, but it can wait until we know if there are other incompatibilities.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=62743

[Markus (顧孟勤), 2010-10-15 05:05:55]

LGTM

You can commit the changelist. Just some minor nitpicks that you are welcome to
ignore.

http://codereview.chromium.org/3775010/diff/1/2
File build/install-chroot.sh (right):

http://codereview.chromium.org/3775010/diff/1/2#newcode259
build/install-chroot.sh:259: readlinepkg=$(sudo schroot -c "${target%bit}" -p --
\
I don't think you technically need the "sudo" in this case. Can you try removing
it.

http://codereview.chromium.org/3775010/diff/1/2#newcode260
build/install-chroot.sh:260: sh -c 'apt-cache search "lib64readline.$" | cut -d
" " -f 1')
This happens to work because $ isn't followed by a valid variable name or
expression. But normally you should have a backslash in front of the $. This
prevents "sh" from trying to expand it.

http://codereview.chromium.org/3775010/diff/1/2#newcode262
build/install-chroot.sh:262: lib64expat1 lib64ncurses5 ${readlinepkg} lib64z1
I guess you are OK with installing lib64readline5 and lib64readline6 at the same
time. Maybe add a comment saying as much. Just so that it is clear this was
intentional.

[Michael Moss, 2010-10-15 15:07:50]

http://codereview.chromium.org/3775010/diff/1/2
File build/install-chroot.sh (right):

http://codereview.chromium.org/3775010/diff/1/2#newcode259
build/install-chroot.sh:259: readlinepkg=$(sudo schroot -c "${target%bit}" -p --
\
At least on the buildbot (Lucid 64), it gives me the error:

W: Group ‘admin’ not found
W: Group ‘admin’ not found
E: Access not authorised
I: You do not have permission to access the schroot service.

Maybe a misconfiguration with the base buildbot image?

http://codereview.chromium.org/3775010/diff/1/2#newcode260
build/install-chroot.sh:260: sh -c 'apt-cache search "lib64readline.$" | cut -d
" " -f 1')
On 2010/10/15 05:05:55, Markus (顧孟勤) wrote:
> This happens to work because $ isn't followed by a valid variable name or
> expression. But normally you should have a backslash in front of the $. This
> prevents "sh" from trying to expand it.

Done.

http://codereview.chromium.org/3775010/diff/1/2#newcode262
build/install-chroot.sh:262: lib64expat1 lib64ncurses5 ${readlinepkg} lib64z1
Yeah, I wasn't worried about conflicts, though it is cleaner to just install
one. Changed to grab the latest version.

[Markus (顧孟勤), 2010-10-15 16:52:37]

On Fri, Oct 15, 2010 at 08:07, <mmoss@chromium.org> wrote:

> W: Group ‘admin’ not found
> W: Group ‘admin’ not found
> E: Access not authorised
> I: You do not have permission to access the schroot service.
>
> Maybe a misconfiguration with the base buildbot image?


Ah, good call. I probably should document this somehow. If you take a closer
look at the "install-chroot.sh" script, you'll see that it gives users in
the "admin" group full access to the chroot environment without having to
call "sudo".

This was done under the assumption that the primary user on the machine is
likely going to be in the "admin" group.

This is probably true on all of our desktops, but on the build machines I
might not be true. Maybe, we need a command line option to override the
group? And then we need to decide which group is appropriate for the
buildbots.


Markus