Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Unified Diff: chrome/browser/policy/mock_configuration_policy_provider.h

Issue 3774003: Cleanup and style guideline conformance for policy implementation (Closed) Base URL: git://codf21.jail/chromium.git
Patch Set: fix windows build and tests Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/policy/mock_configuration_policy_provider.h
diff --git a/chrome/browser/policy/mock_configuration_policy_provider.h b/chrome/browser/policy/mock_configuration_policy_provider.h
index a7fe270305f5887a237af4a64d2276640635d26d..8ba8a88348aa933617ddba66acafd9bce18d431d 100644
--- a/chrome/browser/policy/mock_configuration_policy_provider.h
+++ b/chrome/browser/policy/mock_configuration_policy_provider.h
@@ -18,31 +18,17 @@ namespace policy {
// values for polices.
class MockConfigurationPolicyProvider : public ConfigurationPolicyProvider {
public:
- MockConfigurationPolicyProvider()
- : ConfigurationPolicyProvider(
- ConfigurationPolicyPrefStore::GetChromePolicyDefinitionList()) {
- }
- ~MockConfigurationPolicyProvider() {
- STLDeleteValues(&policy_map_);
- }
+ MockConfigurationPolicyProvider();
+ virtual ~MockConfigurationPolicyProvider();
- typedef std::map<ConfigurationPolicyStore::PolicyType, Value*> PolicyMap;
-
- void AddPolicy(ConfigurationPolicyStore::PolicyType policy, Value* value) {
- std::swap(policy_map_[policy], value);
- delete value;
- }
+ void AddPolicy(ConfigurationPolicyType policy, Value* value);
// ConfigurationPolicyProvider method overrides.
- virtual bool Provide(ConfigurationPolicyStore* store) {
- for (PolicyMap::const_iterator current = policy_map_.begin();
- current != policy_map_.end(); ++current) {
- store->Apply(current->first, current->second->DeepCopy());
- }
- return true;
- }
+ virtual bool Provide(ConfigurationPolicyStoreInterface* store);
private:
+ typedef std::map<ConfigurationPolicyType, Value*> PolicyMap;
+
PolicyMap policy_map_;
};

Powered by Google App Engine
This is Rietveld 408576698