Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Side by Side Diff: chrome/browser/prefs/command_line_pref_store.h

Issue 3774003: Cleanup and style guideline conformance for policy implementation (Closed) Base URL: git://codf21.jail/chromium.git
Patch Set: fix windows build and tests Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_PREFS_COMMAND_LINE_PREF_STORE_H_ 5 #ifndef CHROME_BROWSER_PREFS_COMMAND_LINE_PREF_STORE_H_
6 #define CHROME_BROWSER_PREFS_COMMAND_LINE_PREF_STORE_H_ 6 #define CHROME_BROWSER_PREFS_COMMAND_LINE_PREF_STORE_H_
7 #pragma once 7 #pragma once
8 8
9 #include "base/basictypes.h" 9 #include "base/basictypes.h"
10 #include "base/command_line.h" 10 #include "base/command_line.h"
11 #include "base/scoped_ptr.h" 11 #include "base/scoped_ptr.h"
12 #include "chrome/common/pref_store.h" 12 #include "chrome/common/pref_store.h"
13 13
14 class DictionaryValue; 14 class DictionaryValue;
15 15
16 // This PrefStore keeps track of preferences set by command-line switches, 16 // This PrefStore keeps track of preferences set by command-line switches,
17 // such as proxy settings. 17 // such as proxy settings.
18 class CommandLinePrefStore : public PrefStore { 18 class CommandLinePrefStore : public PrefStore {
19 public: 19 public:
20 explicit CommandLinePrefStore(const CommandLine* command_line); 20 explicit CommandLinePrefStore(const CommandLine* command_line);
21 virtual ~CommandLinePrefStore(); 21 virtual ~CommandLinePrefStore();
22 22
23 // PrefStore methods: 23 // PrefStore methods:
24 virtual PrefReadError ReadPrefs(); 24 virtual PrefReadError ReadPrefs();
25 virtual DictionaryValue* prefs(); 25 virtual DictionaryValue* prefs() const { return prefs_.get(); }
26 26
27 protected: 27 protected:
28 // Logs a message and returns false if the proxy switches are 28 // Logs a message and returns false if the proxy switches are
29 // self-contradictory. Protected so it can be used in unit testing. 29 // self-contradictory. Protected so it can be used in unit testing.
30 bool ValidateProxySwitches(); 30 bool ValidateProxySwitches();
31 31
32 private: 32 private:
33 // Weak reference.
34 const CommandLine* command_line_;
35
36 scoped_ptr<DictionaryValue> prefs_;
37
38 struct StringSwitchToPreferenceMapEntry { 33 struct StringSwitchToPreferenceMapEntry {
39 const char* switch_name; 34 const char* switch_name;
40 const char* preference_path; 35 const char* preference_path;
41 }; 36 };
42 static const StringSwitchToPreferenceMapEntry string_switch_map_[];
43 37
44 // |set_value| indicates what the preference should be set to if the switch 38 // |set_value| indicates what the preference should be set to if the switch
45 // is present. 39 // is present.
46 struct BooleanSwitchToPreferenceMapEntry { 40 struct BooleanSwitchToPreferenceMapEntry {
47 const char* switch_name; 41 const char* switch_name;
48 const char* preference_path; 42 const char* preference_path;
49 bool set_value; 43 bool set_value;
50 }; 44 };
51 static const BooleanSwitchToPreferenceMapEntry boolean_switch_map_[]; 45 static const BooleanSwitchToPreferenceMapEntry boolean_switch_map_[];
52 46
53 // Using the string and boolean maps, apply command-line switches to their 47 // Using the string and boolean maps, apply command-line switches to their
54 // corresponding preferences in this pref store. 48 // corresponding preferences in this pref store.
55 void ApplySimpleSwitches(); 49 void ApplySimpleSwitches();
56 50
51 // Weak reference.
52 const CommandLine* command_line_;
53
54 scoped_ptr<DictionaryValue> prefs_;
55
56 static const StringSwitchToPreferenceMapEntry string_switch_map_[];
57
57 DISALLOW_COPY_AND_ASSIGN(CommandLinePrefStore); 58 DISALLOW_COPY_AND_ASSIGN(CommandLinePrefStore);
58 }; 59 };
59 60
60 #endif // CHROME_BROWSER_PREFS_COMMAND_LINE_PREF_STORE_H_ 61 #endif // CHROME_BROWSER_PREFS_COMMAND_LINE_PREF_STORE_H_
OLDNEW
« no previous file with comments | « chrome/browser/policy/mock_configuration_policy_store.h ('k') | chrome/browser/prefs/command_line_pref_store.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698