Scroll new apps into view when they are installed.

Scroll new apps into view when they are installed.

Also, minor adjustment to spacing at bottom of
scrollable areas.

BUG=59235
TEST=Install enough apps so that the apps section scrolls, 
and then install one more. Apps section should scroll to 
bottom so that you can see the animation happen.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=62977

[arv (Not doing code reviews), 2010-10-15 19:33:16]

Can you use scrollIntoViewIfNeeded?

erik



On Fri, Oct 15, 2010 at 12:15,  <aa@chromium.org> wrote:
> Reviewers: arv,
>
> Description:
> Scroll new apps into view when they are installed.
>
> Also, minor adjustment to spacing at bottom of
> scrollable areas.
>
> BUG=59235
> TEST=Install enough apps so that the apps section scrolls,
> and then install one more. Apps section should scroll to
> bottom so that you can see the animation happen.
>
> Please review this at http://codereview.chromium.org/3771007/show
>
> Affected files:
>  M chrome/browser/resources/ntp/apps.css
>  M chrome/browser/resources/ntp/apps.js
>
>
> Index: chrome/browser/resources/ntp/apps.css
> diff --git a/chrome/browser/resources/ntp/apps.css
> b/chrome/browser/resources/ntp/apps.css
> index
>
43d0e21a7eb4d290d4a947a587413b6fc7e52cc9..52018f3a98a8a074c06f32cfe6b77672a91e1c55
> 100644
> --- a/chrome/browser/resources/ntp/apps.css
> +++ b/chrome/browser/resources/ntp/apps.css
> @@ -1,5 +1,9 @@
>  /* Apps */
>
> +#apps-maxiview {
> +  padding-bottom: 10px;
> +}
> +
>  #apps-content {
>   /*
>   Allow one less than the natural number of columns so that there is space
> for
> Index: chrome/browser/resources/ntp/apps.js
> diff --git a/chrome/browser/resources/ntp/apps.js
> b/chrome/browser/resources/ntp/apps.js
> index
>
9f4daa0d1979c82cff893329baf8852cc9886ec1..2694cbeb8d67d40b8ebbce30fecd14b71157c66e
> 100644
> --- a/chrome/browser/resources/ntp/apps.js
> +++ b/chrome/browser/resources/ntp/apps.js
> @@ -244,6 +244,9 @@ var apps = (function() {
>         div.setAttribute('new', 'new');
>         // Delay changing the attribute a bit to let the page settle down a
> bit.
>         setTimeout(function() {
> +          // Make sure the new icon is scrolled into view.
> +          document.body.scrollTop = document.body.scrollHeight;
> +
>           // This will trigger the 'bounce' animation defined in apps.css.
>           div.setAttribute('new', 'installed');
>         }, 500);
>
>
>

[Aaron Boodman, 2010-10-15 19:36:24]

On Fri, Oct 15, 2010 at 3:26 PM, Erik Arvidsson <arv@chromium.org> wrote:
> Can you use scrollIntoViewIfNeeded?

I don't think it would work since it needs to scroll down far enough
to get out from under neat the masks.

- a

[arv (Not doing code reviews), 2010-10-18 18:55:51]

LGTM